Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShdrAdapter: Listen on configurable IP address #20

Closed
MRIIOT opened this issue Mar 4, 2022 · 7 comments
Closed

ShdrAdapter: Listen on configurable IP address #20

MRIIOT opened this issue Mar 4, 2022 · 7 comments

Comments

@MRIIOT
Copy link

MRIIOT commented Mar 4, 2022

IP address to listen on should be configurable with the option to listen on all interfaces (0.0.0.0).

private async Task ClientListener(CancellationToken cancel)
{
do
{
try
{
var address = IPAddress.Parse("127.0.0.1");
_listener = new TcpListener(address, Port);
_listener.Start();

@PatrickRitchie
Copy link
Contributor

You're correct this should be configurable. I will make an Address property that will default to all interfaces as you mentioned.

I have a large commit coming up that I will most likely add early next week along with a new Release. I will include this change in with that commit.

@MRIIOT
Copy link
Author

MRIIOT commented Mar 4, 2022

Looking forward to it. I'm ready to do more testing.

@PatrickRitchie
Copy link
Contributor

This should be fixed in 0e50b3b

The TcpListener now listens on Any address. This may need to be configurable in the configuration file in the future.

 private async Task ClientListener(CancellationToken cancel)
        {
            do
            {
                try
                {
                    _listener = new TcpListener(IPAddress.Any, Port);
                    _listener.Start();

@MRIIOT
Copy link
Author

MRIIOT commented Mar 26, 2022

Will test in a Docker setup this week.

@MRIIOT
Copy link
Author

MRIIOT commented Mar 28, 2022

@PatrickRitchie , can you update Nuget package?

@PatrickRitchie
Copy link
Contributor

@MRIIOT Yes I will update the Nuget package and create a new Release tonight. I had a few minor other changes that I wanted to include in that Release as well.

@MRIIOT
Copy link
Author

MRIIOT commented Mar 29, 2022

Works perfect in a Docker environment.

@MRIIOT MRIIOT closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants