Update tour generation to account for whether tours are open or closed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmutikainen
commented
Nov 26, 2024
jmutikainen
commented
- Tour rates by tour type and age group take into account whether tour are open or closed
- Open tours are considered half of closed tours in calculations
|
The name of youngest age group doesn't match its data (Helmet history), which should probably be changed sometime... |
zptro
requested changes
Nov 26, 2024
There was a problem hiding this comment.
This causes AssertionError: 0.34241463698614005 != 0.34376735936254194 within 7 places (0.0013527223764018825 difference) in
lem-model-system/Scripts/tests/integration/test_models.py
Lines 55 to 57 in 9ea63db
This check might seem silly, but it is to make sure all changes that cause model result changes are intentional. Could you please change the comparison value in the test?
zptro
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.