Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rat SPN structures #92

Merged
merged 9 commits into from
Oct 19, 2021
Merged

Rat SPN structures #92

merged 9 commits into from
Oct 19, 2021

Conversation

khosravipasha
Copy link
Contributor

Allows to make RAT-spn structures in Juice

@khosravipasha
Copy link
Contributor Author

Few changes that might want to do:

  • In the leaves currently doing fully_factorized_circuit which might have more than a few variables, leads to having Mult nodes with many children, might want to replace with equivalent fully factorized but only with 2 children per Mult node.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #92 (17e63c4) into master (8b45db2) will decrease coverage by 0.82%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   70.31%   69.49%   -0.83%     
==========================================
  Files          38       38              
  Lines        2850     2993     +143     
==========================================
+ Hits         2004     2080      +76     
- Misses        846      913      +67     
Impacted Files Coverage Δ
src/ProbabilisticCircuits.jl 100.00% <ø> (ø)
src/structurelearner/rat_spn.jl 97.40% <97.40%> (ø)
src/plain_prob_nodes.jl 100.00% <100.00%> (ø)
src/gradient_based_learning.jl 45.40% <0.00%> (-16.81%) ⬇️
src/queries/marginal_flow.jl 53.15% <0.00%> (-3.59%) ⬇️
src/queries/sample.jl 45.45% <0.00%> (-0.55%) ⬇️
src/Utils/Utils.jl
src/Utils/misc.jl 41.33% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b45db2...17e63c4. Read the comment docs.

@khosravipasha khosravipasha merged commit aad9d14 into master Oct 19, 2021
@khosravipasha khosravipasha deleted the rat-spn branch November 8, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant