Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EVI and MAR functions for mixtures #49

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Add EVI and MAR functions for mixtures #49

merged 4 commits into from
Jan 21, 2021

Conversation

RenatoGeh
Copy link
Contributor

Hi,

This PR adds EVI and MAR functions for mixtures. It additionally adds manual docs for these functions. See #28 and #48.

I wasn't sure how you guys wanted tests for these changes. I've marked this as a draft PR so we can coordinate. Feel free to add commits to this PR.

Thanks

@RenatoGeh RenatoGeh mentioned this pull request Jan 18, 2021
Closed
@RenatoGeh RenatoGeh marked this pull request as ready for review January 20, 2021 20:51
@RenatoGeh
Copy link
Contributor Author

Added EVI and MAR tests for mixtures. Since SharedProbCircuits don't have IO functions, I had to run learning inside the testsets. I'll add set verbose to false to avoid the printing during testing if #50 is merged.

@guyvdbroeck guyvdbroeck requested a review from MhDang January 20, 2021 20:56
@RenatoGeh RenatoGeh changed the title [WIP] Add EVI and MAR functions for mixtures Add EVI and MAR functions for mixtures Jan 20, 2021
@MhDang MhDang merged commit 2a6ece0 into Tractables:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MhDang MhDang Awaiting requested review from MhDang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenatoGeh @MhDang