[WIP] BitCircuitPair: bit circuits for pair of ciruict (eg for expectations) #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code working for bit circuit for pair of circuits. Took some debugging but now the numbers for expectation match with other implementations.
Todo:
having pr-constraint by itself is useful to have.
Comments:
Did not add Pair leaves for constant nodes (TRUE,FALSE) probably won't need them. But added for literals pairs that don't agree like (-3 and 3) but probably don't need those either as its always not satisfied.
Right now had to also store bit circuit for both the PC and LC as well, maybe can optimize that part. This was to get the paramters easier. Without having to repeat them.
3.
In small cases its not faster really. In the biggest case I tried its about 1.5-2x times faster than the other two implementations I tried. Probably still room for optimization, did not use many of the tricks yet like@views
.a. Recursive Exp
b. Bit circuit cpu
c. Bit circuit cpu & reuse bit circuit + memories
d. Bit circuit gpu
e. Bit circuit gpu & reuse bitcuit + memories