reinstate plotting functionality #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 46.80% 47.84% +1.04%
==========================================
Files 17 18 +1
Lines 1391 1417 +26
==========================================
+ Hits 651 678 +27
+ Misses 740 739 -1
Continue to review full report at Codecov.
|
|
|
||
|
|
||
|
|
||
| function fromUAI(filename) |
There was a problem hiding this comment.
We don't need the factor graph compilation anymore? Or I guess will be adding it back later? Oh I guess since we don't have vtrees and SDDs right now in PCs.jl we cannot have these either.
There was a problem hiding this comment.
It depends on SDD compilation, which is in logic circuits. We can add it to LogicCircuits.jl one day and then allow conversion from Logic to Prob circuits.
src/input_distributions.jl
Outdated
| @@ -78,6 +81,9 @@ num_categories(d::Categorical) = length(logps(d)) | |||
| num_parameters(n::Categorical, independent) = | |||
| num_categories(n) - (independent ? 1 : 0) | |||
|
|
|||
| latex(d::Categorical) = | |||
| "Categorical("*join(params(d), ", ")*")" | |||
There was a problem hiding this comment.
Maybe can shorten this by doing "Cat" and rounding the params into like 2-3 digits.
Also since we are printing sum nodes params not in log domain I guess we can do same here and take exp.
No description provided.