Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for indicator and categorical input distributions in JPC format #111

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

guyvdbroeck
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #111 (ee6a0ce) into master (4eb2931) will increase coverage by 0.98%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   45.81%   46.80%   +0.98%     
==========================================
  Files          17       17              
  Lines        1362     1391      +29     
==========================================
+ Hits          624      651      +27     
- Misses        738      740       +2     
Impacted Files Coverage Δ
src/abstract_nodes.jl 86.95% <ø> (ø)
src/plain_nodes.jl 86.11% <0.00%> (-2.47%) ⬇️
src/io/jpc_io.jl 99.00% <96.55%> (-1.00%) ⬇️
src/input_distributions.jl 47.76% <100.00%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb2931...ee6a0ce. Read the comment docs.

test/helper/pc_equals.jl Show resolved Hide resolved
@guyvdbroeck guyvdbroeck changed the title add support for categorical input distributions in JPC format add support for indicator and categorical input distributions in JPC format Feb 21, 2022
Copy link
Contributor

@khosravipasha khosravipasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seesm to be easy to support other potential node types later.

@guyvdbroeck guyvdbroeck merged commit 9c41bbe into master Feb 22, 2022
@guyvdbroeck guyvdbroeck deleted the io branch February 22, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants