Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/Load operations not fully supported #86

Closed
5 of 6 tasks
khosravipasha opened this issue May 23, 2020 · 3 comments
Closed
5 of 6 tasks

Save/Load operations not fully supported #86

khosravipasha opened this issue May 23, 2020 · 3 comments

Comments

@khosravipasha
Copy link
Contributor

khosravipasha commented May 23, 2020

Keeping track of what's needed

For the load/save of Strudel (mixtures), one suggestion is that save all related files and metadata in a single Zip file (with appendix .strudel). We need the structure, the vtree, the mixture weights, and paramters. (maybe more). One option is using ZipFile.jl. Also see Juice-jl/LogicCircuits.jl#12

@khosravipasha khosravipasha changed the title Save logic circuit without a vtree given Save logic circuits not fully supported Jul 19, 2020
@khosravipasha khosravipasha changed the title Save logic circuits not fully supported Save/Load operations not fully supported Nov 10, 2020
@khosravipasha
Copy link
Contributor Author

Also related to Tractables/LogicCircuits.jl#40

@guyvdbroeck
Copy link
Member

The first 3 check boxes above are resolved in Tractables/LogicCircuits.jl#99
The remaining ones should be moved to https://github.com/Juice-jl/ProbabilisticCircuits.jl

@khosravipasha khosravipasha transferred this issue from Tractables/LogicCircuits.jl Sep 18, 2021
@khosravipasha
Copy link
Contributor Author

@guyvdbroeck Last one was saving strudel models whichI think we have now in `ensemble_io.jl"?
so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants