Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for bottom-up vtree learning #63

Closed
guyvdbroeck opened this issue Mar 12, 2021 · 1 comment
Closed

Failing test for bottom-up vtree learning #63

guyvdbroeck opened this issue Mar 12, 2021 · 1 comment
Assignees

Comments

@guyvdbroeck
Copy link
Member

Under Julia 1.6rc2, there are tests under https://github.com/Juice-jl/ProbabilisticCircuits.jl/blob/master/test/structurelearner/vtree_learner_tests.jl that fail, because the learned bottom-up vtree is different from the one hardcoded in the test:

julia> print_tree(v)
━PlainVtreeInnerNode(1,2,3,4,5,6,7,8,9,10)
 ┣━PlainVtreeInnerNode(2,4,6,8,9,10)
 ┃ ┣━PlainVtreeInnerNode(2,8,9,10)
 ┃ ┃ ┣━PlainVtreeInnerNode(2,8)
 ┃ ┃ ┃ ┣━PlainVtreeLeafNode(2)
 ┃ ┃ ┃ ┗━PlainVtreeLeafNode(8)
 ┃ ┃ ┗━PlainVtreeInnerNode(9,10)
 ┃ ┃   ┣━PlainVtreeLeafNode(9)
 ┃ ┃   ┗━PlainVtreeLeafNode(10)
 ┃ ┗━PlainVtreeInnerNode(4,6)
 ┃   ┣━PlainVtreeLeafNode(4)
 ┃   ┗━PlainVtreeLeafNode(6)
 ┗━PlainVtreeInnerNode(1,3,5,7)
   ┣━PlainVtreeInnerNode(1,7)
   ┃ ┣━PlainVtreeLeafNode(1)
   ┃ ┗━PlainVtreeLeafNode(7)
   ┗━PlainVtreeInnerNode(3,5)
     ┣━PlainVtreeLeafNode(3)
     ┗━PlainVtreeLeafNode(5)
julia> p1
2-element Vector{Vector{Vector{T} where T}}:
 [[[1, 7], [9, 10]], [4, 6]]
 [[2, 8], [3, 5]]

It's unclear whether this is just randomness of ties (perhaps a change in one of the dependencies) or whether there is a bug.

@guyvdbroeck
Copy link
Member Author

closed by 64c3004
bottom-up vtree learning now requires the user to manually import BlossomV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants