Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API improvement] Remove data from *BitCircuit signiture #32

Closed
khosravipasha opened this issue Nov 11, 2020 · 1 comment
Closed

[API improvement] Remove data from *BitCircuit signiture #32

khosravipasha opened this issue Nov 11, 2020 · 1 comment
Assignees
@khosravipasha
Labels
good first issue Good for newcomers low priority

Comments

@khosravipasha
Copy link
Contributor

We give data to BitCircuit but they only use it to count how many num_features there are, don't need the data for that. Might be better to just give the count. Unless I am missing something here.

https://github.com/Juice-jl/LogicCircuits.jl/blob/e42cd0806fafbf4db09138fdceb8b88a991d5c3d/src/bit_circuit.jl#L73-L75

Because of this then all ParamBitCircuit, etc also have to pass in the data.
@khosravipasha khosravipasha self-assigned this Nov 11, 2020
@khosravipasha khosravipasha changed the title Remove data from *BitCircuit signiture [API improvement] Remove data from *BitCircuit signiture Nov 24, 2020
@guyvdbroeck guyvdbroeck added the good first issue Good for newcomers label Mar 29, 2021
@khosravipasha
Copy link
Contributor Author

This is also will be gone in v0.4 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khosravipasha khosravipasha

Labels
good first issue Good for newcomers low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guyvdbroeck @khosravipasha