Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_as_dot Clean up #7

Closed
khosravipasha opened this issue May 23, 2020 · 0 comments
Closed

save_as_dot Clean up #7

khosravipasha opened this issue May 23, 2020 · 0 comments
Labels
low priority low priority

Comments

@khosravipasha
Copy link
Collaborator

khosravipasha commented May 23, 2020 •
edited
Loading

See

https://github.com/Juice-jl/ProbabilisticCircuits.jl/blob/421735abfc930ca37003c0f540a299a9d7743a49/src/LoadSave/circuit_savers.jl#L141-L197

and

https://github.com/Juice-jl/ProbabilisticCircuits.jl/blob/421735abfc930ca37003c0f540a299a9d7743a49/src/LoadSave/circuit_savers.jl#L141-L197

Move as much as save_as_dot possible to LogicCircuits to avoid duplicate code. See pull request #6. The main difference is that logic circuits don't have parametersm everything else seems duplicate.
@khosravipasha khosravipasha added the low priority low priority label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khosravipasha