Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct_learn reaches assertion error #37

Closed
guyvdbroeck opened this issue Jul 30, 2020 · 3 comments
Closed

struct_learn reaches assertion error #37

guyvdbroeck opened this issue Jul 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@guyvdbroeck
Copy link
Member

vtree = Vtree(784, :balanced);
init_circuit = fully_factorized_circuit(StructLogicCircuit,vtree)
struct_learn(init_circuit; stop=x->false)

eventually gives

ERROR: AssertionError: GateType(or) isa ⋁Gate && (GateType(and) isa ⋀Gate && and in children(or))
Stacktrace:
 [1] split(::PlainStruct⋁Node, ::Tuple{PlainStruct⋁Node,PlainStruct⋁Node}, ::UInt32; depth::Int64, sanity_check::Bool) at /home/guyvdb/space/.julia/dev/LogicCircuits/src/transformations.jl:209
 [2] split_step(::PlainStruct⋁Node; loss::typeof(random_split), depth::Int64, sanity_check::Bool) at /home/guyvdb/space/.julia/dev/LogicCircuits/src/transformations.jl:329
 [3] struct_learn(::PlainStruct⋁Node; primitives::Array{typeof(split_step),1}, kwargs::Dict{typeof(split_step),NamedTuple{(:loss, :depth),Tuple{typeof(random_split),Int64}}}, maxiter::Int64, stop::var"#1#2") at /home/guyvdb/space/.julia/dev/LogicCircuits/src/transformations.jl:343
 [4] top-level scope at REPL[8]:1
@guyvdbroeck guyvdbroeck added the bug Something isn't working label Jul 30, 2020
@YitaoLiang
Copy link
Collaborator

In the process of trying to reproduce this error.
It seems like the initial structure cannot be properly saved.

@guyvdbroeck
Copy link
Member Author

(I can no longer reproduce the issue, it may have been accidentally fixed)

@khosravipasha
Copy link
Collaborator

@MhDang @guyvdbroeck @YitaoLiang
this seems to be fixed, should I close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants