Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player currentTime is used both for setting the time and display the time. #142

Open
nicolabortignon opened this issue Feb 5, 2016 · 0 comments
Assignees

Comments

@nicolabortignon
Copy link
Contributor

We use a dispatch from the View to the redux to update the player timeline. It uses the state property currentTime.

We also use the same property to update from the reducer the currentTime (to be played).
Ie, when we skip track or when we want to play a specific cue point in a track.

We need to separate the two behavior, and try to avoid loops while doing that.

Ideally:

  • the audio tag in the view update the currentTime sending a message to the reducer.
  • the reducer update the startingTime in the state. The player picks up the change and sequentialy the currentTime is going to be dispatched. Probably we'll need to handle this in a componentReceivedProperty method. Unfortunately we will need to invalidate the startingTime when such behaviour is not requested.
@nicolabortignon nicolabortignon self-assigned this Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant