Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting -> Saving always triggers #97

Closed
stonier opened this issue May 5, 2018 · 7 comments
Closed

Quitting -> Saving always triggers #97

stonier opened this issue May 5, 2018 · 7 comments
Milestone

Comments

@stonier
Copy link
Collaborator

stonier commented May 5, 2018

Quitting the visualiser still launches the dialog even when the configuration should not have changed.

  • Start a delphyne instance with the gui
  • Save the configuration
  • Exit
  • Restart
  • Immediately exit
  • -> Dialog
@stonier stonier added this to the Milestone 3 milestone May 5, 2018
@stonier stonier modified the milestones: Milestone 3, Milestone 2 May 20, 2018
@caguero
Copy link
Contributor

caguero commented May 31, 2018

I cannot reproduce it following your instructions. Is still happening if you follow the same steps?

@stonier
Copy link
Collaborator Author

stonier commented Jun 1, 2018

Yeah, still happening. I'm exiting via either File->Quit or the window decoration's exit button. Either way, always get a dialog except the time I actually save the dialog via File->Quit. I'm testing with all_cars_on_dragway.py.

Anything I can perhaps debug for you here?

@caguero
Copy link
Contributor

caguero commented Jun 1, 2018

Could you remove your .delphyne/xxx.config file and try again just in case?

@stonier
Copy link
Collaborator Author

stonier commented Jun 1, 2018

Have been doing that when testing. Still having the problem.

@caguero
Copy link
Contributor

caguero commented Jun 2, 2018

Based on a debugging session, the problem appears to be a difference between the window poses. We still don't understand why it happens but we're considering to avoid saving the window position. Ideally, this should be configurable because there are other use cases for Ignition Gui where remembering the window position is still useful.

@caguero
Copy link
Contributor

caguero commented Jun 6, 2018

Please, try #119 when you have a chance to verity the fix.

@caguero
Copy link
Contributor

caguero commented Jun 6, 2018

Fixed in #119.

@caguero caguero closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants