Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0: Undo and Skip buttons are not accessible in the Paused state after being Delayed #184

Closed
Toufool opened this issue Oct 30, 2022 · 2 comments
Closed

2.0.0: Undo and Skip buttons are not accessible in the Paused state after being Delayed #184

Toufool opened this issue Oct 30, 2022 · 2 comments

Comments

@Toufool
Copy link
Owner

Toufool commented Oct 30, 2022 •
edited
Loading

Delayed State (this is correct)
image

Paused State right after being delayed (Undo and Skip should be re-enabled if appropriate)
image

Confirmed this is working in 1.6.1:

Delayed State:
image

Paused state right after being delayed:
image
@Avasam
Copy link
Collaborator

Avasam commented Nov 14, 2022 •
edited
Loading

In other words, the UI isn't restored. Even the image name is missing (removed by delay code path)

I've also noticed that with both pause and delay together, if an image is an immediate (first frame) match, the delay sometimes won't be triggered.

@Avasam Avasam mentioned this issue Nov 19, 2022
Merged
@Toufool
Copy link
Owner Author

Toufool commented Jan 14, 2023

Confirmed that these buttons are now accessible after a split is delayed and then paused. closing

@Toufool Toufool closed this as completed Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Avasam @Toufool