Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary variable vals #414

Open
bryates opened this issue May 17, 2024 · 0 comments
Open

Remove temporary variable vals #414

bryates opened this issue May 17, 2024 · 0 comments
Assignees
@bryates @Andrew42 @ywan2

Comments

@bryates
Copy link
Contributor

bryates commented May 17, 2024 •
edited
Loading

topeft/topeft/modules/datacard_tools.py

Line 878 in e96fedb

vals = wcs_dict # set wcs to certain values from command line

Why do we create the temporary variable vals here? As far as I can tell it only gets passed to self.decompose(). Why not just pass wcs_dict directly?

Originally posted by @Andrew42 in #406 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryates bryates

@Andrew42 Andrew42

@ywan2 ywan2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bryates @Andrew42 @ywan2