Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exports test fails on 32bit versions of node #97

Open
CurryKitten opened this issue Sep 1, 2016 · 0 comments
Open

exports test fails on 32bit versions of node #97

CurryKitten opened this issue Sep 1, 2016 · 0 comments

Comments

@CurryKitten
Copy link

CurryKitten commented Sep 1, 2016

Having been running tests on various platforms, and noticed some commonality with the test suite in node-time failing on 32bit versions of node, whilst passing on the 64bit versions.

If I run the test suit via npm test on 32bit, we see the error -

1) exports localtime() should not segfault on a NaN Date value:

      AssertionError: { invalid: true } deepEqual { seconds: 0,
  minutes: 0,
  hours: 0,
  dayOfMonth: 1,
  month: 0,
  year: 70,
  dayOfWeek: 4,
  dayOfYear: 0,
  isDay
      + expected - actual

       {
      -  "invalid": true
      +  "dayOfMonth": 1
      +  "dayOfWeek": 4
      +  "dayOfYear": 0
      +  "gmtOffset": 0
      +  "hours": 0
      +  "isDaylightSavings": false
      +  "minutes": 0
      +  "month": 0
      +  "seconds": 0
      +  "timezone": "UTC"
      +  "year": 70
       }

      at Context.<anonymous> (test/exports.js:49:14)

Is this expected to pass on 32bit node ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant