Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a net.Socket instead of a plain EventEmitter for replaying proxy errors #83

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Use a net.Socket instead of a plain EventEmitter for replaying proxy errors #83

merged 3 commits into from
Oct 17, 2019

Conversation

lpinca
Copy link
Contributor

@lpinca lpinca commented Oct 16, 2019

Fixes: #81

@lpinca
Copy link
Contributor Author

lpinca commented Oct 16, 2019

Hmm there is no {readable,writable}.destroy() on Node.js 6.

lpinca
lpinca commented Oct 16, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@lpinca lpinca force-pushed the gh-81 branch 2 times, most recently from f6e2538 to 093b8de Compare October 16, 2019 20:34
TooTallNate
TooTallNate reviewed Oct 16, 2019
View reviewed changes
index.js
var net = require('net');
var tls = require('tls');
var url = require('url');
var events = require('events');
var stream = require('stream');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var stream = require('stream');

@TooTallNate
Copy link
Owner

This looks great! Thanks for the PR

@TooTallNate TooTallNate changed the title Use a Duplex instead of a plain EventEmitter Use a net.Socket instead of a plain EventEmitter for replaying proxy erros Oct 16, 2019
@TooTallNate TooTallNate changed the title Use a net.Socket instead of a plain EventEmitter for replaying proxy erros Use a net.Socket instead of a plain EventEmitter for replaying proxy errors Oct 16, 2019
@TooTallNate TooTallNate merged commit 4c0d37e into TooTallNate:master Oct 17, 2019
@lpinca lpinca deleted the gh-81 branch October 17, 2019 05:56
@nimadera nimadera mentioned this pull request Oct 21, 2019
Closed
TooTallNate pushed a commit that referenced this pull request Oct 25, 2019
@lpinca @TooTallNate
Use a net.Socket instead of a plain EventEmitter for replaying pr…
34ea884 
…oxy errors (#83)

* Run CI on pull requests

* Use a `Duplex` instead of a plain `EventEmitter`

Fixes: #81

* Use a new and closed `net.Socket` instead of a `Duplex`
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 4, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Jan 24, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 9, 2021
Closed
Open
Closed
Open
Closed
Open
Closed
This was referenced Mar 12, 2021
Merged
Closed
Open
Merged
Closed
Open
Merged
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

this.socket.destroy is not a function
2 participants
@lpinca @TooTallNate