Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TotalVariation proximal in place #1650

Open
MargaretDuff opened this issue Jan 15, 2024 · 1 comment · May be fixed by #1941
Open

TotalVariation proximal in place #1650

MargaretDuff opened this issue Jan 15, 2024 · 1 comment · May be fixed by #1941
Assignees
@MargaretDuff
Labels
bug Something isn't working
Milestone
v24.3.0

Comments

@MargaretDuff
Copy link
Member

MargaretDuff commented Jan 15, 2024 •
edited
Loading

TotalVariation proximal is not calculated in place correctly. This was spotted when trying to run SIRT with a TV constraint in #1514.

data = dataexample.SIMPLE_PHANTOM_2D.get(size=(128,128))
plt.figure()
plt.imshow(data.as_array())
plt.show()
out=data.geometry.allocate('random')
TotalVariation().proximal(data, tau=1, out=out)
plt.figure()
plt.imshow(out.as_array())
plt.show()

gives
image
image

data = dataexample.SIMPLE_PHANTOM_2D.get(size=(128,128))
plt.figure()
plt.imshow(data.as_array())
plt.show()
TotalVariation().proximal(data, tau=1, out=data)
plt.figure()
plt.imshow(data.as_array())
plt.show()

gives
image
image
@MargaretDuff MargaretDuff mentioned this issue Jan 15, 2024
Closed
@MargaretDuff MargaretDuff added the bug Something isn't working label Jan 15, 2024
@MargaretDuff MargaretDuff self-assigned this Jan 15, 2024
@MargaretDuff
Copy link
Member Author

Need to also test with strong convexity constant >0

@MargaretDuff MargaretDuff linked a pull request Oct 1, 2024 that will close this issue
Open
9 tasks
@MargaretDuff MargaretDuff added this to the v24.3.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MargaretDuff MargaretDuff

Labels
bug Something isn't working
Projects
CIL work
Status: Todo
Work plan
Status: ToDo
Milestone
v24.3.0
1 participant
@MargaretDuff