Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating run() without any arguments #1938

Open
MargaretDuff opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1940
Open

Deprecating run() without any arguments #1938

MargaretDuff opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1940
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MargaretDuff
Copy link
Member

Description

Using algo.run() gives a deprecation warning but will still run, I think up to some internal max_iterations if it exists
image

As we have deprecated max_iterations which raises an error if passed, I think it makes more sense to raise an error with a note that it has been deprecated and they must pass a number of iterations to run.

This was discussed at the events and engagement meeting this week

Environment

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)
@MargaretDuff MargaretDuff added the bug Something isn't working label Sep 27, 2024
@MargaretDuff MargaretDuff changed the title Deprecating run() without any arguments in the algorithm toolkit Deprecating run() without any arguments Sep 27, 2024
@MargaretDuff MargaretDuff added this to the v24.3.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

2 participants