We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Masker processor needs refactoring to improve efficiency.
The way that Masker performs averaging and interpolating needs improving.
The averaging or interpolating is along a single axis only.
The processor starts by looping over the axis to be averaged along:
CIL/Wrappers/Python/cil/processors/Masker.py
Line 211 in b10d15d
Then it updates any Masked values at the first index on that axes before looping over the remaining indices and repeating.
However, there isn't necessarily a masked value at each index on the axis. It would make more sense for the loop to be over the values in the mask.
import cil, sys print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
The Masker processor needs refactoring to improve efficiency.
The way that Masker performs averaging and interpolating needs improving.
The averaging or interpolating is along a single axis only.
The processor starts by looping over the axis to be averaged along:
CIL/Wrappers/Python/cil/processors/Masker.py
Line 211 in b10d15d
Then it updates any Masked values at the first index on that axes before looping over the remaining indices and repeating.
However, there isn't necessarily a masked value at each index on the axis. It would make more sense for the loop to be over the values in the mask.
Environment
The text was updated successfully, but these errors were encountered: