Support <meta>/<title> in Fiber renderers
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added
SwiftUI compatibility
ezraberch
reviewed
Jul 6, 2022
| @@ -15,6 +15,11 @@ | |||
| // Created by Carson Katri on 7/16/20. | |||
| // | |||
|
|
|||
| @_spi(TokamakCore) | |||
| public struct _WindowGroupTitle: _PrimitiveView { | |||
| public let title: Text? | |||
There was a problem hiding this comment.
Does this need to be an optional?
In WindowGroups where title is nil, it should be more efficient to not use a _WindowGroupTitle at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility with the
.htmlMeta()and.htmlTitle()modifiers added in #483. 2 special cases were also added:WindowGrouphas atitleparameter, which can now be used to specify the<title>tag in Fiber renderers by extending the_WindowGroupTitleview.In SwiftUI, if a
_BackgroundStyleModifierreaches the top of the scene, it will extend into the top safe area. This PR adds the"theme-color"meta tag when the background style reaches the top of the scene: