Properly parse unquoted attributes (please🙏?)

[piccojs]

Whenever I parse this string:

<p type=bold>hello mom!</p>

I get unexpected results:

{
  tagName:"p",
  attributes:{
    type:null,
    bold:null
  },
  children:["hello mom!"]
}

I know this is an xml parser but wouldn't it just make sense to generate:

{
  tagName:"p",
  attributes:{
    type:"bold"
  },
  children:["hello mom!"]
}

Please consider adding such type parsing in the next bug fix, I love your library! 🥰🥰

[TobiasNickel]

thanks, this really is a bug. I can confirm it, in a quick test.
it need to be fixed in the parseNode method between line 200 and 220:

tXml/tXml.js

Lines 199 to 224 in 0dddcb2

	if ((c > 64 && c < 91) || (c > 96 && c < 123)) {
	//if('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'.indexOf(S[pos])!==-1 ){
	var name = parseName();
	// search beginning of the string
	var code = S.charCodeAt(pos);
	while (code && code !== singleQuoteCC && code !== doubleQuoteCC && !((code > 64 && code < 91) || (code > 96 && code < 123)) && code !== closeBracketCC) {
	pos++;
	code = S.charCodeAt(pos);
	}
	if (code === singleQuoteCC || code === doubleQuoteCC) {
	var value = parseString();
	if (pos === -1) {
	return {
	tagName,
	attributes,
	children,
	};
	}
	} else {
	value = null;
	pos--;
	}
	attributes[name] = value;
	}
	pos++;
	}

To be honest, even I find the code at line 204 a bit difficult to read, But with spending some time we should be able to figure this out.

[tuananh]

but that one is invalid xml right? there's suppose to be quote (single or double) around bold?

<p type="bold">hello mom!</p>

[TobiasNickel]

right, but still many html pages do not have quotes. the values then can not contain any space.