Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting "helper functions" into a separate package #6

Open
brshallo opened this issue May 21, 2021 · 1 comment
Open

Consider splitting "helper functions" into a separate package #6

brshallo opened this issue May 21, 2021 · 1 comment
Labels
revisit this issue should be revisited at a later point in time

Comments

@brshallo
Copy link

For someone new to {dplyover} it may be nice to have documentation / reference page be focused just on funs that are clearly dplyr::across() extensions (so don't get distracted by funs they probably shouldn't worry about when first starting). This seems to be especially true if you are planning on expanding on these helper funs.


This might just be more of a hassle than anything to implement at this point though... Also may want to have be together for the purposes of convenience and seems these funs are only meant to be used in {dplyover} so may not really make sense to have be separate.

...though could make analogy with how {tidyselect} is separate from {dplyr} (but is not a great one because {tidyselect} gets used in a bunch of tidyverse packages and serves a different purpose than the helper funs in {dplyover}). However there does seem to be tidy precedents for having these extensions be modularized into distinct package (e.g. fabletools and fable, or various other "tidy" ecosystems that seem to keep packages very modular.)

@TimTeaFan
Copy link
Owner

I understand both arguments. At the moment I would leave all helpers functions as part of the package. Prominent (non-tidyverse) packages such as data.table have helper functions like rleid which are often used outside of the data.table context. The question is, when would the {dplyover} helper functions warrant their own package? I'd say, if all (or at least 1. & 3. or 1. & 2.) of the follow conditions are met:

  1. the helper functions are useful enough to be used outside the context of the over-across function family
  2. {dplyover} has a large user base and a substantial part (at least 20%) of the user load {dplyover} just for the helper functions
  3. the helper functions are used by more than one package.

I personally use some of the functions regularly, like dist_values. So I think at least some of the helper functions meet condition 1. But at the moment the package does not have enough users and also no other packages which would rely on its helper functions.

@TimTeaFan TimTeaFan added the revisit this issue should be revisited at a later point in time label May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revisit this issue should be revisited at a later point in time
Projects
None yet
Development

No branches or pull requests

2 participants