Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to try 1-(0.1 N) scoring? #14

Open
wiseodd opened this issue Apr 4, 2018 · 3 comments
Open

Any way to try 1-(0.1 N) scoring? #14

wiseodd opened this issue Apr 4, 2018 · 3 comments
Labels

Comments

@wiseodd
Copy link

wiseodd commented Apr 4, 2018

Hi,

I noticed in the new version of the paper, you mentioned 1-(0.1 N) scoring and I'd like to try that.
I didn't see any parameter for this in the code though.
Do you have instructions how to do that somewhere?

@TimDettmers
Copy link
Owner

For 1-(0.1N) scoring, I hacked my code just to get some evaluation metrics. I will look into this and will see if it makes sense to integrate it into the code.

@SawanKumar28
Copy link

SawanKumar28 commented Nov 28, 2018

Hi @TimDettmers , would it be possible for you to share the changes necessary for 1-(0.1N) or else, 1-1 scoring. I believe Table 7 in the paper has ablation results with 1-1 scoring.

@TimDettmers
Copy link
Owner

One reason why I did not provide my code for this is that it is very messy and cannot be combine with my framework.

The simplest solution might be to sample from the label matrix e2_multi and select N% of the labels and use this as the label for the model. When you calculate the loss, you need to index both the output of the model and the e2_multi labels with the same index. In pseudo code:

p= 0.1 //10% sampling
N = e2_multi.sum(1)
idx = sample_index(e2_multi, N)
new_labels = e2_mullti[:, idx]
pred = model.forward(e1, rel)
new_pred = pred[:, new_idx]
loss = model.loss(new_pred, new_labels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants