Refactored Subarray and SubarrayPartitioner towards addressing #93 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-maley
reviewed
Feb 24, 2020
tiledb/sm/misc/types.h
Outdated
| @@ -109,6 +117,9 @@ class Range { | |||
| /** An N-dimensional range, consisting of a vector of 1D ranges. */ | |||
| typedef std::vector<Range> NDRange; | |||
|
|
|||
| /** A value as a vector of bytes. */ | |||
| typedef std::vector<uint8_t> Value; | |||
There was a problem hiding this comment.
Could we rename this to something less generic? Maybe something like ByteVecValue?
There was a problem hiding this comment.
Sure thing, I can do that change.
joe-maley
approved these changes
Feb 24, 2020
stavrospapadopoulos
force-pushed
the
sp/refactor_subarray
branch
from
0d2a26c to
1ddc1c1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.