Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring towards splitting coordinates #1465

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

stavrospapadopoulos
Copy link
Member

Refactoring towards addressing #93. Changes mainly around comparison of coordinates in the presence of separate coordinate tiles.

Copy link
Contributor

@joe-maley joe-maley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor style comments below. I ignored the 'TODO's in reader.cc, figuring that you will fix them in a follow-up patch.

tiledb/sm/misc/comparators.h Outdated Show resolved Hide resolved
tiledb/sm/misc/comparators.h Outdated Show resolved Hide resolved
tiledb/sm/misc/comparators.h Show resolved Hide resolved
tiledb/sm/misc/comparators.h Show resolved Hide resolved
tiledb/sm/misc/comparators.h Show resolved Hide resolved
tiledb/sm/misc/comparators.h Show resolved Hide resolved
tiledb/sm/query/reader.cc Outdated Show resolved Hide resolved
…of coordinates in the presence of separate coordinate tiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants