Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption key validation map grows indefinitely #969

Closed
tdenniston opened this issue Sep 27, 2018 · 1 comment
Closed

Encryption key validation map grows indefinitely #969

tdenniston opened this issue Sep 27, 2018 · 1 comment
Labels
encryption internals
Milestone
1.6.0

Comments

@tdenniston
Copy link
Contributor

This map:

TileDB/tiledb/sm/storage_manager/storage_manager.h

Line 694 in 66d31d1

std::map<std::string, std::unique_ptr<EncryptionKeyValidation>>

currently grows with every new array being opened, and entries are never removed.

When cache eviction on array close is implemented, the corresponding entries in this map should also be removed.
@tdenniston tdenniston added this to the 1.4.0 milestone Sep 27, 2018
@tdenniston tdenniston self-assigned this Sep 27, 2018
@tdenniston tdenniston modified the milestones: 1.4.0, 1.5.0 Sep 27, 2018
@tdenniston tdenniston mentioned this issue Sep 27, 2018
Closed
@tdenniston tdenniston removed their assignment Sep 27, 2018
@tdenniston tdenniston modified the milestones: 1.5.0, 1.6.0 Dec 13, 2018
@tdenniston
Copy link
Contributor Author

Closed via #1197 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encryption internals
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@tdenniston