diff --git a/HISTORY.md b/HISTORY.md index e9b44ba914..49ba7f395d 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -4,7 +4,7 @@ * Wheels will no longer be supported for macOS 10.14 Mojave; the minimum supported macOS version is now 10.15 Catalina [#1080](https://github.com/TileDB-Inc/TileDB-Py/pull/1080) # Bug Fixes -* Correct issue where writing a NumPy array containing emppy strings would error out [#1089](https://github.com/TileDB-Inc/TileDB-Py/pull/1089) +* Correct issue where writing a NumPy array containing empty strings would error out [#1089](https://github.com/TileDB-Inc/TileDB-Py/pull/1089) # TileDB-Py 0.14.4 Release Notes diff --git a/tiledb/tests/test_libtiledb.py b/tiledb/tests/test_libtiledb.py index f9f136c753..d02b57dbb9 100644 --- a/tiledb/tests/test_libtiledb.py +++ b/tiledb/tests/test_libtiledb.py @@ -1799,12 +1799,6 @@ def test_varlen_write_bytes(self): assert_array_equal(A, T.multi_index[1 : len(A)][""]) def test_varlen_sparse_all_empty_strings(self): - # this test addresses a fix for specific need for reads on a - # large existing array, see - # https://github.com/TileDB-Inc/TileDB-Py/pull/475 - # we currently have to write a placeholder at the end to - # avoid zero-length cell error - # TODO: follow-up with improved testing for empty var-length/strings A = np.array(["", "", "", "", ""], dtype=object) dim_len = len(A) uri = self.path("varlen_all_empty_strings") @@ -3486,6 +3480,10 @@ def test_from_numpy_empty_str(self, empty_str, num_strs): with tiledb.open(uri, "r") as A: assert_array_equal(A[:], np_array) + if has_pandas(): + print(A.query(return_arrow=True).df[:]) + # assert_array_equal(A.query(use_arrow=True).df[:][""], np_array) + # assert_array_equal(A.query(use_arrow=False).df[:][""], np_array) class ConsolidationTest(DiskTestCase):