Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding quarter to the floor_date and round_date functions #18

Open
7 of 11 tasks
DoktorMike opened this issue Oct 13, 2024 · 1 comment
Open
7 of 11 tasks

Adding quarter to the floor_date and round_date functions #18

DoktorMike opened this issue Oct 13, 2024 · 1 comment

Comments

@DoktorMike
Copy link
Contributor

DoktorMike commented Oct 13, 2024 •
edited by drizk1
Loading

In finance it's really common to use Quarters for planning. It would be cool if floor date and round date could use quarters in addition.

Thus

floor_date(dt, "quarter")

which would turn 2024-05-20 to 2024-04-01 since April 1 is the beginning of the second quarter. In lubridate the following units are supported

  • second
  • minute
  • hour
  • day
  • week
  • month
  • bimonth
  • quarter
  • season
  • halfyear
  • year

I've used the checkmark to indicate which ones that are currently implemented in TidierDates.jl. It would be nice to support the same as lubridate. Happy to take a stab at it if there's interest.
@DoktorMike DoktorMike mentioned this issue Oct 13, 2024
Merged
@drizk1
Copy link
Member

drizk1 commented Oct 13, 2024 •
edited
Loading

This is a great expansion, I love it and always welcome new contributors!

I'm not in finance so if there's other missing features from lubridate you need plz do raise an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DoktorMike @drizk1