-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDEA] - display: grid for editor and preview #7771
Comments
Hi @BurningTreeC I don't think we need grid here, flexbox should be sufficient. |
Hi @Jermolene yes I tried flexbox and it looked promising. Then I went fullscreen with the editor like I do in the codemirror 6 plugin and tried making the editor and the preview fill the available space while the toolbar stays full width and height auto. I couldn't manage that using flexbox - but using grid I could |
Hi @BurningTreeC OK, we'd need one flex container for the toolbar and the main body, and another one for dividing the body into the editor and the preview pane, which I see isn't going to fly with the current HTML structure. Would you be interested in drafting a PR? |
Do you mean a PR that's using grid? |
Thanks @BurningTreeC yes. |
Is your feature request related to a problem? Please describe.
I always thought the width of 49% for the editor and the preview is a strange workaround
I tried making the parent div of the toolbar, editor and preview
display: grid
using the fix-body-editor-refresh branch and that works well and we can display them side by side without gapThe text was updated successfully, but these errors were encountered: