Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for DiffEqCallbacks v3 compat with FMI v0.10.x #222

Closed
sharanry opened this issue Jun 19, 2024 · 6 comments
Closed

Request for DiffEqCallbacks v3 compat with FMI v0.10.x #222

sharanry opened this issue Jun 19, 2024 · 6 comments

Comments

@sharanry
Copy link
Contributor

Hey @ThummeTo!

This is a request for a patch release on FMI v0.10.x for DiffEqCallbacks v3.x.x.

I already have a branch here for it -- https://github.com/ThummeTo/FMI.jl/compare/v0.10.3...sharanry:sy/bump_diffeqcallback_compat?expand=1

@ThummeTo
Copy link
Owner

HI @sharanry,
sure, just open a PR 👍
(please also increase the version in project.toml, should be v0.10.4, so we can merge directly if the tests pass)

@sharanry
Copy link
Contributor Author

I can't seem to open a PR as there is not branch for v0.10.

@sharanry
Copy link
Contributor Author

I have updated the branch with a patch bump.

@ThummeTo
Copy link
Owner

I created one (v0.10.4) should be based on the commit of the v0.10.3 release. Now you can open a PR to the v0.10.4 branch, so we can check if the tests are running :-)

@ThummeTo
Copy link
Owner

Registration is in progress :)

@sharanry
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants