Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Reduce the number of build warnings #260

Closed
binarymash opened this issue Mar 6, 2018 · 5 comments
Closed

CI - Reduce the number of build warnings #260

binarymash opened this issue Mar 6, 2018 · 5 comments
Assignees
Labels
feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note.

Comments

@binarymash
Copy link
Contributor

New Feature

Reduce the number of build warnings - work ongoing from #253

Motivation for New Feature

We want to minimise the number of build warnings, enforce a common coding style and identify any common gotchas in the code

Steps to Reproduce the Problem

Do a build ;)

Specifications

n/a

@TomPallister
Copy link
Member

@binarymash much appreciated, just had a quick look! Only a few things that i commented on and they are my mistakes! Would be awesome if you have time to fix it :p you thought you got away from tidying up my shit code!

@TomPallister TomPallister added the feature A new feature label Mar 7, 2018
@TomPallister
Copy link
Member

@binarymash thanks for merging chief. Was just in the water poet near Liverpool Street. Was a Huddersfield exciles sticker in the bogs. Exciting.

@TomPallister TomPallister added the help wanted Not actively being worked on. If you plan to contribute, please drop a note. label Mar 13, 2018
@TomPallister TomPallister changed the title Reduce the number of build warnings CI - Reduce the number of build warnings Mar 16, 2018
@simonjefford
Copy link
Contributor

Warnings now 0...

Used a pragma to squash the warning about AddBaseUrl being obsolete as it was test code (and setup code at that). Also, I switched off package analysis to shut up the warning about the summary text (see NuGet/Home#4587 for more).

@TomPallister
Copy link
Member

@simonjefford awesome!! Thanks 👍

AddBaseUrl is some crap that wasn't very well thought out :( I need to get rid of it but focusing on other features at the moment. We have an issue for it!

@TomPallister
Copy link
Member

@binarymash not sure if you want to re-open this but will leave closed for now as @simonjefford (a friend of mine from real life..yes I have two of them!) has helped out here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note.
Projects
None yet
Development

No branches or pull requests

3 participants