-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - Reduce the number of build warnings #260
Comments
@binarymash much appreciated, just had a quick look! Only a few things that i commented on and they are my mistakes! Would be awesome if you have time to fix it :p you thought you got away from tidying up my shit code! |
@binarymash thanks for merging chief. Was just in the water poet near Liverpool Street. Was a Huddersfield exciles sticker in the bogs. Exciting. |
Warnings now 0... Used a pragma to squash the warning about |
@simonjefford awesome!! Thanks 👍 AddBaseUrl is some crap that wasn't very well thought out :( I need to get rid of it but focusing on other features at the moment. We have an issue for it! |
@binarymash not sure if you want to re-open this but will leave closed for now as @simonjefford (a friend of mine from real life..yes I have two of them!) has helped out here! |
New Feature
Reduce the number of build warnings - work ongoing from #253
Motivation for New Feature
We want to minimise the number of build warnings, enforce a common coding style and identify any common gotchas in the code
Steps to Reproduce the Problem
Do a build ;)
Specifications
n/a
The text was updated successfully, but these errors were encountered: