Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up #1377: WebSocketsProxyMiddleware concerns #1707

Open
raman-m opened this issue Sep 29, 2023 · 2 comments
Open

Follow-up #1377: WebSocketsProxyMiddleware concerns #1707

raman-m opened this issue Sep 29, 2023 · 2 comments
Assignees
Labels
feature A new feature proposal Proposal for a new functionality in Ocelot Websockets Ocelot feature: Websockets

Comments

@raman-m
Copy link
Member

raman-m commented Sep 29, 2023

Relates to #1377 #1689

Bug fixes:

Initial issue in #1377:

Code review comment on Sep 28

Expected Behavior / New Feature

The WebSocketsProxyMiddleware class must be redesigned.

Actual Behavior / Motivation for New Feature

The UseWebSocketsProxyMiddleware method enables custom WebSocketsProxyMiddleware in the pipeline.
But there is no usage of native WebSocketMiddleware class which is industry standard. But instead of standard framework middleware a custom WebSocketsProxyMiddleware class was written with custom Invoke method. This is design issue...

Links

Specifications

  • Version: latest, 19.x & .NET 7
@raman-m raman-m added feature A new feature proposal Proposal for a new functionality in Ocelot labels Sep 29, 2023
@raman-m raman-m self-assigned this Sep 29, 2023
@raman-m raman-m added the Websockets Ocelot feature: Websockets label Oct 27, 2023
@raman-m raman-m changed the title Follow-up after merging #1377. WebSocketsProxyMiddleware concerns Follow-up #1377: WebSocketsProxyMiddleware concerns Mar 23, 2024
@raman-m
Copy link
Member Author

raman-m commented Mar 25, 2024

One more concern

@raman-m raman-m added the Oct'24 October 2024 release label Jun 16, 2024
@raman-m raman-m added this to the Summer'24 milestone Jun 16, 2024
@raman-m
Copy link
Member Author

raman-m commented Aug 26, 2024

TODO

Pick up this ticket only after

  • .NET 9 Release in November 2024
  • Ocelot upgrade to net9.0

@raman-m raman-m removed the Oct'24 October 2024 release label Aug 26, 2024
@raman-m raman-m removed this from the September'24 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature proposal Proposal for a new functionality in Ocelot Websockets Ocelot feature: Websockets
Projects
None yet
Development

No branches or pull requests

1 participant