Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Swift 3? #6

Open
Tibb opened this issue Oct 21, 2016 · 3 comments
Open

Doesn't work with Swift 3? #6

Tibb opened this issue Oct 21, 2016 · 3 comments

Comments

@Tibb
Copy link

Tibb commented Oct 21, 2016

Thx for this great tuto, but unfortunately, it doesn't work anymore with Swift 3: the view is directly dismissed when you start to drag.
I reproduce it on my project and I also tried on with this project: same result.
Do you have any idea on how to fix that?
Thanks a lot

@nevinjethmalani
Copy link

Yes, we had the same issue. Will you be releasing a swift 3 version?

@chenr2
Copy link
Collaborator

chenr2 commented Nov 7, 2016

Not sure when I'll be able to get to updating this tutorial. But pull requests are always welcome.

@komayip
Copy link

komayip commented Nov 10, 2016

change
func animationControllerForDismissedController(dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
return DismissAnimator()
}

to

func animationController(forDismissed dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
return DismissAnimator()
}

works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants