-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On some websites scroll bar is not recolored #42
Comments
Thank you for highlighting these instances 👍. I had considered scrollbars once but then forgot about them. This issue will serve as a great reminder. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
With native behaviour, scrollbar colors can either be white or dependent on the website's background color. Modifying it with UltimaDark is straightforward, but I'm wondering of the optimal color logic for it. The simplest approach might involve two fixed colors: a dark grey for the scrollbar thumb and nearly black for the scrollbar track. However, incorporating an alpha value could reproduce in some sort the native relation between scrollbar color and the background. Scrollbars from left to right in above snippet:
|
I would consider it satisfactory. The presence of an alpha channel in the scrollbar thumb means that altering the track with rgba(0,0,0,0.26) has an impact on the color rgba(255,255,255,0.40) of the scrollbar thumb. Investigating the precise match would require adjusting the 0.0.0.0.26 values within the range of 0 to 30 and the 0.15 to 0.40 values approximately, as well as the 255.255.255.40 values from 235 to 255 and the 0.25 to 0.65 values approximately. However, delving into such time consuming fine-tuned adjustments may not be justified. |
I like all four options, but with an infinite number of color combinations, how do we choose the best one? |
This comment was marked as outdated.
This comment was marked as outdated.
I won't tweak scrollbar opacity based on brightness because it involves to much processing for such a simple thing as scrollbars. Doing this would mean figuring out each scrollable part, adjusting opacity during load, and updating it whenever the background or its background-color changes. It's just not practical for managing scrollbars, especially if the background comes from images. Let's stick to the basics and use two fixed colors, whether with or without transparency. |
3rd option with user defined global colors and no transparency or fixed opacity? |
The default setting will be the third option, but users will be able to customize their preferred colors, including opacity. We'll also provide one-click options for suggested styles 1 to 4. |
Resolved in 1.5.34 |
Example site where it doesn't work: https://www.muskokaseaflea.ca/homesplash/
Example site where it works as expected: https://store.muskokaseaflea.ca/index.php?route=product/category&path=33#new_tab
The text was updated successfully, but these errors were encountered: