Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages no longer serializable #219

Open
benmccann opened this issue Aug 12, 2024 · 1 comment · May be fixed by #220
Open

Packages no longer serializable #219

benmccann opened this issue Aug 12, 2024 · 1 comment · May be fixed by #220

Comments

@benmccann
Copy link
Contributor

In get-packages version 1 the returned Packages type was serializable. In version 2 it is not:

export interface Tool {

changesets is stuck on version 1 as a result.

changesets is responsible for more than 80% of the usage of this package: https://packages.ecosyste.ms/registries/npmjs.org/packages/@manypkg%2Fget-packages/dependent_packages?kind=runtime&latest=true&order=desc&sort=downloads

Would you accept a PR to restore the serializability of the return value?

@Andarist
Copy link
Collaborator

Would you accept a PR to restore the serializability of the return value?

I'd be interested in your take on the problem.

When v2 was released I didn't realize that this serializability was needed for Changesets 😢

@benmccann benmccann linked a pull request Aug 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants