Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when two packages have same prefix #107

Open
utkarshk384 opened this issue Aug 26, 2021 · 0 comments · May be fixed by #108
Open

Error when two packages have same prefix #107

utkarshk384 opened this issue Aug 26, 2021 · 0 comments · May be fixed by #108

Comments

@utkarshk384
Copy link

utkarshk384 commented Aug 26, 2021

The issue here is that I have two packages named as @UI/theme and @UI/theme-utils and when I try to use any scripts with @UI/theme the following error is thrown to me:

☔️ error an identifier must only match a single package but "theme" matches the following packages: 
☔️ error @UI/theme
☔️ error @UI/theme-utils

Upon looking at the source code I found the following lines of code that could possibly be causing the issue:

const matchingPackages = packages.filter(pkg => {
return (
pkg.packageJson.name.includes(args[0]) ||
path.relative(root.dir, pkg.dir).includes(args[0])
);
});

This code snippet lies within the runCmd function here.

I suppose that arg[0] might be the package that is calling the CLI command. So, for example, I am currently calling the CLI command for the theme package therefore arg[0] should be @UI/theme.

With that out of the way now I think includes is matching all the packages that have that same name, therefore, causing the issue here. I'll try to make a pull request to fix the issue.

Edit: args[0] doesn't equal to @UI/theme but just theme. I had overlooked some parts of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant