Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need testers! #1

Open
ThexXTURBOXx opened this issue Aug 13, 2022 · 20 comments
Open

We need testers! #1

ThexXTURBOXx opened this issue Aug 13, 2022 · 20 comments
Labels
help wanted Extra attention is needed

Comments

@ThexXTURBOXx
Copy link
Owner

ThexXTURBOXx commented Aug 13, 2022

We are searching for testers for:

The 4.x rewrite

If you want to test the 4.x rewrite, you can already do that by changing the version constraint to flutter_web_auth_2: ^4.0.0-alpha.5
See also here: https://pub.dev/packages/flutter_web_auth_2/versions/4.0.0-alpha.5
Please note the migration guide

Android

I am using this package in production in an app - so I am very sure about its reliability here!

Web

Most of my "quick" tests are done in Edge and Firefox - should also be pretty stable.

Apple

I do not have any devices by Apple. I have no idea how stable the current implementation is. Most testing is necessary here.

Linux

Should be pretty stable, but I only test this occasionally.

Windows

Should be pretty stable, but I only test this occasionally.

@niteshsh4rma
Copy link

@niteshsh4rma Do you perhaps have any Apple devices to test the current state of this fork on Apple devices? :)

Also, I should have invited you to join this project in case you are still interested in maintaining this library!

Sorry to say, but I only have Linux and Windows machine. But I am interested to work on this.

@ThexXTURBOXx
Copy link
Owner Author

Damn, we need to find someone who is able to test this on Apple devices. Otherwise, we need to publish the package without these tests and fix things after first bug reports come in.
I have already tested basic functionality on Android. Let's see if some other platform is causing any problems.
Also, I am thinking about including even more PRs from the original project here (such as the big plugin refactor and so on).

Thanks again for volunteering, also! :)

@AndreiRoze
Copy link

@ThexXTURBOXx, i have iPad and i can make some tests if you provide me what exactly need to test.

@ThexXTURBOXx
Copy link
Owner Author

@AndreiRoze That would be great! Just running the example and seeing if it compiles, runs, and successfully authenticates you would be very nice :)
Thanks in advance!

@AndreiRoze
Copy link

AndreiRoze commented Aug 17, 2022

@ThexXTURBOXx, I finished tests, looks like it work correct, "preferEphemeral" option also work correct. I tested with your example and also I tested with GitHub Oauth2.
Screenshots from test with example:
exm1
exm2

Screenshots from test with GitHub:
gh1
gh2

@ElDuderini
Copy link

If you need another iOS/android tester, I am open to it. I have been looking for an update to this plugin for a long time and want to see it succeed! I was tempted to fiddle with the code myself since authentication on android didn't work for me.

@ThexXTURBOXx
Copy link
Owner Author

ThexXTURBOXx commented Aug 17, 2022

@AndreiRoze Thank you very much! Very nice that it instantly works. That gives me hope :)

@ElDuderini If you want, you can of course also test it :)

As soon as I got confirmations for all the currently supported platforms, I will publish the first version of flutter_web_auth_2 to pub.dev (However, I also want to finish #2 first)

@ThexXTURBOXx
Copy link
Owner Author

I will postpone #2 because I am unsure if I want to finish it anyways.
Let's see what the future brings. For now, I am planning on publishing the first version of this package today

@ThexXTURBOXx ThexXTURBOXx changed the title Tests on Apple devices We need testers! Aug 20, 2022
@ThexXTURBOXx ThexXTURBOXx added the help wanted Extra attention is needed label Aug 20, 2022
@ThexXTURBOXx ThexXTURBOXx reopened this Aug 20, 2022
@ThexXTURBOXx ThexXTURBOXx pinned this issue Aug 20, 2022
@ThexXTURBOXx
Copy link
Owner Author

1.0.0 has just been published!

@JAicewizard
Copy link

Any reason this is still open? We just deployed an app with version 2.02 and IOS support, everything seems to be working fine ATM.

@ThexXTURBOXx
Copy link
Owner Author

It's always good to have people that can test changes that (could) affect Apple products since I don't have access to any :)

@adrian-moisa
Copy link

adrian-moisa commented May 17, 2024

@ThexXTURBOXx I was able to setup a full E2E testing pipeline using patrol and a digital ocean VPS. I run waydroid on debian. Waydroid is a simulator which requires far less CPU/mem compared to adb emulator. Therefore I am able to run the entire app on a 8CPU 16GB ram vps and have room for spare (without a GPU). Speed is decent. I can see and interact with the screen via wayvnc. Additionally I used a ssh script to detect when a chrome process is opened. It then taps on the login button. Which in turn returns control back to the flutter app. From there on my typical test suite runs. So overall fully automating android testing is possible including the auth client. Not sure what can be done for iOS in this fashion. Would this setup help you for testing purposes? I can provide a setup guide/presentation.

@ThexXTURBOXx
Copy link
Owner Author

Thank you very much for your offer! For my tests, I am basically just testing it on the physical devices I own (or even use on a day-to-day basis).
I own a Windows computer, a Linux laptop, two Android devices and I have several Web browsers installed on these.
So, most platforms should be pretty stable. With the exception of Apple.
The best solution would obviously be me buying some MacBook and iPhone (both do not even need to be the newest models), but even that is a bit too expensive for me since I would only need them to properly test this package.
Hence, my current focus would be testers for the 4.x pre-release, but especially users/devs that can test on iOS and MacOS.

But, again, thank you very much anyway! :)

@adrian-moisa
Copy link

I'm replying from a Mac M1. I can run the basic tests. I also have a colleague that can take a spot if I'm not available. As for iOS I don't have one myself, but I'll have to have one to test my own flutter app. Until then I could test on my gf phone. I need to test my own app soon anyway. Might as well help you on this one.

@ThexXTURBOXx
Copy link
Owner Author

Perfect, thank you very much! Your help would be much appreciated - especially when I try to solve #104. Should be a pretty straightforward change, but I fear that I will break something in the process

@Rexios80
Copy link

Rexios80 commented Aug 8, 2024

@ThexXTURBOXx I mainly dev on macOS/iOS. What do you want done to test this? I need WASM support, so having version 4 released as stable would be ideal.

@ThexXTURBOXx
Copy link
Owner Author

@Rexios80 Thanks for volunteering! :)
It would be nice if one could just try out the basic functionality of the package on Apple devices, i.e., changing some of the options and see if they are applied correctly.
Now with 4.x being rather stable, one could also try out the new Universal links support (#117).
And no, I didn't forget also your PR (#26) which laid out the groundwork for Universal links ;)

As soon as someone can verify that everything seems to be working rather smoothly on these platforms, I will be more than happy to release a stable 4.0.0 version (after revisiting the migration guide - maybe I forgot to mention something...)

@Rexios80
Copy link

Rexios80 commented Aug 8, 2024

How feasible would it be to write integration tests for this functionality? That would make outsourcing testing a lot easier.

@ThexXTURBOXx
Copy link
Owner Author

If someone wants to write them, go ahead! Sadly, I am already rather busy already maintaining all my projects here on GitHub to keep them alive and don't have time to implement them myself

@Rexios80
Copy link

Rexios80 commented Aug 8, 2024

I'm implementing this in an iOS/Android/web app this month, so it should be tested pretty thoroughly in a couple weeks. If I don't get back to you please mention me to ask for an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants