Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keysBlacklist option to keysBlocklist #16

Open
thompiler opened this issue Nov 6, 2020 · 2 comments
Open

Update keysBlacklist option to keysBlocklist #16

thompiler opened this issue Nov 6, 2020 · 2 comments

Comments

@thompiler
Copy link

Howdy!

We recently updated the phpbrake library to use updated terminology for the filtering option. keysBlacklist is still supported but is deprecated in favor of keysBlocklist. Users that set keysBlacklist will see a message like this in their log though it will still work at filtering params:

phpbrake: keysBlacklist is a deprecated option. Use keysBlocklist instead.

I've done some testing myself (full disclosure: Laravel novice) with this library in an example Laravel app and I think simply updating these two mentions to keysBlocklist would do the trick:

'keysBlacklist' => null, #list of keys containing sensitive information that must be filtered out

'keysBlacklist' => null, #list of keys containing sensitive information that must be filtered out

I'd be happy to submit a PR for that if you think that would be helpful.

@TheoKouzelis
Copy link
Owner

Hi @thompiler

Thanks for the heads up. I will get that change done tonight.

@TheoKouzelis
Copy link
Owner

Hi @thompiler Yes please if you could create a PR that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants