Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with dependencies not being set #237

Closed
YHordijk opened this issue May 17, 2024 · 1 comment · Fixed by #238
Closed

Issue with dependencies not being set #237

YHordijk opened this issue May 17, 2024 · 1 comment · Fixed by #238
Assignees
Labels
bug Something isn't working

Comments

@YHordijk
Copy link
Contributor

I found an issue where dependencies are supposed to be set by the workflow, but they are not used when submitting it.

@YHordijk YHordijk added the bug Something isn't working label May 17, 2024
@YHordijk YHordijk self-assigned this May 17, 2024
@YHordijk
Copy link
Contributor Author

The issue seemed to be that in the dependency method we were using the conditional
if otherjob.can_skip, but it is a method and not a property so it always is True. Further, this would not work if the job is currently being managed by Slurm, as then can_skip always returns True, even if it is currently running or pending. We needed to add a new method called in_queue, which checks if the job is being managed by slurm

@YHordijk YHordijk linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant