Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to upgrade Exoplayer? #1711

Closed
mark-carrington opened this issue Aug 12, 2019 · 4 comments
Closed

Plans to upgrade Exoplayer? #1711

mark-carrington opened this issue Aug 12, 2019 · 4 comments

Comments

@mark-carrington
Copy link

Feature Request

Upgrade Exoplayer dependency to 2.10.1 or newer (if available).

Why it is needed

We are currently using both 'react-native-video' (version 5.0.0) and 'react-native-track-player' (version 1.1.8), but these libraries have a dependency conflict on Exoplayer (see below):

react-native-track-player -> com.google.android.exoplayer.exoplayer-core:2.10.1
react-native-video -> com.google.android.exoplayer.*:2.9.3

Whilst it is possible to downgrade 'react-native-track-player' to earlier version (1.1.4) to get the same version Exoplayer, we lose some of the nice new features in 1.1.8. I would expect others to hit this problem soon too, as I wouldn't believe using both these libraries together is that uncommon.

So I wanted to find out if you had plans to update the ExoPlayer libraries to a newer version?

Thanks
Mark

@CHaNGeTe
Copy link
Contributor

I am preparing a PR with the update, but dunno the ETA.

@jariwalabhavesh
Copy link

jariwalabhavesh commented Aug 12, 2019

@CHaNGeTe : I am also facing same issue with react-native-track-player and react-native-video
if you can create version that support before android-x as well.

@matteocollina
Copy link

I have the same issue with react-native-video 4.4.4 and react-native 0.60.4
only in Android, iOS works

Schermata 2019-08-13 alle 18 12 49

@benoitdion
Copy link
Collaborator

We upgraded Exoplayer in #1753! We'll release the change in a 5.1-alpha soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants