Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting using hard defaults on first load #15

Open
TheWhiteWolves opened this issue Jun 9, 2016 · 1 comment
Open

Setting using hard defaults on first load #15

TheWhiteWolves opened this issue Jun 9, 2016 · 1 comment
Labels
Milestone

Comments

@TheWhiteWolves
Copy link
Owner

TheWhiteWolves commented Jun 9, 2016

https://app.roll20.net/forum/permalink/3491471/

I can't seem to get the inverted private mode to work. Using the Github 1.2 version.

invertedMarker = true and the list behaves as default. [GM] maps are in private while unlabelled maps are in public.

EDIT: The plot thickens. I have no idea why, but the inversion now works in the API.
"{"debug":true,"gmNotify":true,"marker":"[GM]","invertedMarker":true}"

However, when I copy pasted the script from that API to another game, the inversion doesn't work:
"{"debug":true,"gmNotify":true,"marker":"[GM]","invertedMarker":false}"

Didn't change a thing between the copy/paste, nor are either game running any other APIs.
I have no idea what happened.

See the above post, it looks like on first loading the script into a new campaign it is not loading the users changes to the config into the state, it is loading the hard coded defaults and then pulls the users change on the second load.

@TheWhiteWolves TheWhiteWolves added this to the v1.3 milestone Jun 9, 2016
@TheWhiteWolves
Copy link
Owner Author

Possible help for this would be to check and update each of the options individually and to keep a cached copy of the config to compare to.

Use the cached copy to see if changes have been made since the last load, if they have then then update them, may also allow runtime config edits this way.

@TheWhiteWolves TheWhiteWolves modified the milestones: v1.4, v1.3 Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant