Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Redistribute Toxin Tractor Gamma damage bonus to stay within 50% max #889

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Aug 13, 2022

Reference:

This change redistributes GLA Toxin Tractor Gamma bonuses to be consistent with the intended bonus from the tool tip.

CONTROLBAR:ToolTipGLAUpgradeAnthraxGamma
US: "+50% damage bonus to all toxin units"

Note: There is a follow up change to this one:

Stats

fixed_toxin_truck

Rationale

The Toxin Tractor damage values are just a bit wild. The first 2 Gamma ToxinTruckGun's give 64% and 63% relative bonus over Anthrax Beta, while the 3rd gives 42%. The first Gamma ToxinTruckSprayer gives 0% bonus over Anthrax Beta, but the others 33% and 28% relative bonus over Anthrax Beta. This change redistributes the damages to make more sense.

Weapon Bonus over Anthrax Beta Bonus over Toxin Change over Toxin
Original Chem_ToxinTruckGunGamma +64% +105%
Original Chem_ToxinTruckGunGammaPlusOne +63% +145%
Original Chem_ToxinTruckGunGammaPlusTwo +42% +185%
Original Chem_ToxinTruckSprayerGamma +0% +25%
Original Chem_ToxinTruckSprayerGammaPlusOne +33% +75%
Original Chem_ToxinTruckSprayerGammaPlusTwo +28% +125%
Patched Chem_ToxinTruckGunGamma (this) +40% +75% -30%
Patched Chem_ToxinTruckGunGammaPlusOne (this) +50% +125% -20%
Patched Chem_ToxinTruckGunGammaPlusTwo (this) +50% +200% +15%
Patched Chem_ToxinTruckSprayerGamma (this) +20% +50% +25%

@xezon xezon added Design Is a matter of game design Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Aug 13, 2022
@xezon xezon merged commit 51460aa into main Aug 14, 2022
@xezon xezon deleted the toxin-tractor-gamma-damage branch August 14, 2022 14:17
@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 14, 2022

Haven't you weakened the Tractor quite a bit? I don't think this is a good change. The Tractor is used with original weapon more than it is with scrap up.

@xezon
Copy link
Collaborator Author

xezon commented Aug 14, 2022

It has a tiny bit less bonus overall. Although the Nozzle gun is weaker before Scrap, the Sprayer gun is stronger before Scrap, so there is benefit still.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 14, 2022

Yes I can see that, perhaps I'm reading it wrong, but it was 64% before and 40% now? That's quite a big jump without a proper reasoning I'd say. And the gun is used quite a lot, I'd say more important than the sprayer.

@xezon
Copy link
Collaborator Author

xezon commented Aug 14, 2022

You can make new suggestions on how to redistribute if you take issue with it. Right now the damage progression is very organized and logical and certainly better than originally.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 14, 2022

Whilst it is organised and logical, it doesn't make it the right one as you've taken away a lot of damage from the unit for no real reason, I don't see as a reason to nerf it. Make them all at 50% at the minimum. I don't see why it should go down to 40%.

How about, all damages at 60%? This nerfs the first 2 very slightly, but buffs the last, which is hardly seen, so would not make much of a difference.

Although I don't agree with this next idea myself, (at the moment anyway,) perhaps the original damage staying the same and then increasing the others to match it.

@xezon
Copy link
Collaborator Author

xezon commented Aug 14, 2022

We can make the Chem_ToxinTruckGunGamma 18.75 damage to be a 50% bonus over Anthrax Beta. Anything higher will exceed the 50% Gamma bonus.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 14, 2022

Yup, I'd prefer a flat 50%.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 14, 2022

We can make the Chem_ToxinTruckGunGamma 18.75 damage to be a 50% bonus over Anthrax Beta. Anything higher will exceed the 50% Gamma bonus.

this sounds more logical.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 14, 2022

The top table is probably not so easy to read for outsiders to be fair:

  • better add top headers that splits clearly splits it in groups of 3 (non scrapped / scrapped / double scrapped).
  • rename current headers (to standard toxin / beta upgrade / gamma upgrade) instead of the code names.

I'm trying to understand the rationale of the change though, the maingun is nerfed just to align with the tooltip?
Are 64% and 63% really "too much"? Is there any other reason?

Guess changes are unnoticeable in practice though, so it's not that I care too much about it. But I feel in the general the fixation on value alignment is a bit too much?

@xezon
Copy link
Collaborator Author

xezon commented Aug 14, 2022

Take some time and study the presented data.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 14, 2022

Take some time and study the presented data.

It's easy to get lost in how the stuff is ordered and readability is bad.

xezon added a commit that referenced this pull request Aug 28, 2022
@ImTimK ImTimK added the GLA Affects GLA faction label Nov 6, 2022
@xezon xezon added Nerf Makes a thing less powerful and removed Nerf Makes a thing less powerful labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial Is controversial Design Is a matter of game design GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants