Fix: GLA Buildings are missing Fortified Structures visuals during sell

[commy2]

• fix GLA Buildings with Fortified Structure upgrade have no appropriate model when sold #470

This change makes it so buildings with Fortified Structures upgrade do not lose their "visual fortifications" (sand bags, barbed wire etc.) while being sold.

This does not affect any damage taken.

Note that the fortifications will not be shown while the building is being constructed. However, the armor bonus from Fortified Structures does not apply while the building is being constructed either, so this is the desired behaviour.

[xezon]

This is huge change. Did you all write it by hand or did you copy from other places? It is not clear to me what level of attention this Review requires.

[commy2]

It was done by hand.

To every building with Fortified Structures I added this block:

expand

    ; Patch104p @bugfix 13/08/2022 Keep Fortified Structure visuals while selling the building.
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD
      Model              = xxxxxE
      Animation          = xxxxxE.xxxxxE
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD DAMAGED
      Model              = xxxxxE_D
      Animation          = xxxxxE_D.xxxxxE_D
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD REALLYDAMAGED
      Model              = xxxxxE_E
      Animation          = xxxxxE_E.xxxxxE_E
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT
      Model              = xxxxxE_N
      Animation          = xxxxxE_N.xxxxxE_N
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT DAMAGED
      Model              = xxxxxE_DN
      Animation          = xxxxxE_DN.xxxxxE_DN
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT REALLYDAMAGED
      Model              = xxxxxE_EN
      Animation          = xxxxxE_EN.xxxxxE_EN
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD SNOW
      Model              = xxxxxE_S
      Animation          = xxxxxE_S.xxxxxE_S
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD SNOW DAMAGED
      Model              = xxxxxE_DS
      Animation          = xxxxxE_DS.xxxxxE_DS
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD SNOW REALLYDAMAGED
      Model              = xxxxxE_ES
      Animation          = xxxxxE_ES.xxxxxE_ES
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT SNOW
      Model              = xxxxxE_NS
      Animation          = xxxxxE_NS.xxxxxE_NS
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT SNOW DAMAGED
      Model              = xxxxxE_DNS
      Animation          = xxxxxE_DNS.xxxxxE_DNS
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End
    ConditionState       = AWAITING_CONSTRUCTION PARTIALLY_CONSTRUCTED ACTIVELY_BEING_CONSTRUCTED GARRISONED SOLD NIGHT SNOW REALLYDAMAGED
      Model              = xxxxxE_ENS
      Animation          = xxxxxE_ENS.xxxxxE_ENS
      AnimationMode      = LOOP
      Flags              = ADJUST_HEIGHT_BY_CONSTRUCTION_PERCENT
    End

where xxxxx is replaced with the appropriate model.

If you test this, all you need to do is open the map with all buildings placed and sell with and without Fortifed Structures. If you want to be thorough, you have to damage them as well once slightly and once badly.

Every commit fixes one building type. The first one does all GLA Barracks (including fakes and GC_).

[xezon]

I skimmed through the lines and it appears to look ok.