Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unqiue Module Tag for Cash Bounty Module #701

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Jul 17, 2022

This PR fixes a patch exclusive error when opening the World Builder:

---------------------------
Assertion Failure
---------------------------
ASSERTION FAILURE: addModuleInfo - ERROR defining module 'FireWeaponUpdate' on thing template 'Boss_CommandCenter'.  The module 'FireWeaponUpdate' has the tag 'ModuleTag_15' which must be unique among all modules for this object, but the tag 'ModuleTag_15' is also already on module 'GenerateMinefieldBehavior' within this object.

Please make unique tag names within an object definition


Abort->exception; Retry->debugger; Ignore->continue

The FireWeaponUpdate module and thus the bug was introduced by: #595

This fix gives the module the previous tag of the CashBountyPower module which was removed in #595.

@commy2 commy2 added the Bug Something is not working right label Jul 17, 2022
@@ -1362,7 +1362,7 @@ Object Boss_CommandCenter

; Patch104p @bugfix commy2 24/10/2021 Fix Command Center scaffold unlocks Cash Bounty.

Behavior = FireWeaponUpdate ModuleTag_15
Behavior = FireWeaponUpdate ModuleTag_96
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future you can assign new modules a _Patch104p suffix and less generic name, such as ModuleTag_CashBounty_Patch104p. This will avoid collisions and make it descriptive.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xezon xezon self-requested a review July 17, 2022 07:39
@commy2 commy2 merged commit a215ea2 into main Jul 17, 2022
@commy2 commy2 deleted the fix-cashbounty-assertion-error branch July 17, 2022 07:42
xezon pushed a commit that referenced this pull request Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants