From 10cf67d815ca0d1f0828ea6fed310135ba6128be Mon Sep 17 00:00:00 2001 From: xezon <4720891+xezon@users.noreply.github.com> Date: Wed, 13 Sep 2023 11:12:41 +0200 Subject: [PATCH 1/2] Change: Increase Internet Center sabotage duration of GLA Saboteur from 15000 to 60000 ms --- Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini | 3 ++- Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini | 3 ++- Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini index 32a278ff7..5648733dd 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini @@ -17482,9 +17482,10 @@ Object Demo_GLAInfantrySaboteur Behavior = SabotageFakeBuildingCrateCollide SabotageTag_07 BuildingPickup = Yes End + ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes - SabotageDuration = 15000 + SabotageDuration = 60000 End ; --- begin Death modules --- diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini index e297201fb..ee17648be 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini @@ -4434,9 +4434,10 @@ Object GLAInfantrySaboteur Behavior = SabotageFakeBuildingCrateCollide SabotageTag_07 BuildingPickup = Yes End + ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes - SabotageDuration = 15000 + SabotageDuration = 60000 End ; --- begin Death modules --- diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini index ded6440d4..6597f03bd 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini @@ -17846,9 +17846,10 @@ Object Slth_GLAInfantrySaboteur Behavior = SabotageFakeBuildingCrateCollide SabotageTag_07 BuildingPickup = Yes End + ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes - SabotageDuration = 15000 + SabotageDuration = 60000 End ; Patch104p @bugfix hanfield 28/08/2021 Replaced FX_RebelDie with FX_SaboteurDie. From 1677f36072769cc63ba567220dcf70daec40cb93 Mon Sep 17 00:00:00 2001 From: xezon <4720891+xezon@users.noreply.github.com> Date: Sun, 9 Jun 2024 14:10:51 +0200 Subject: [PATCH 2/2] Add yaml --- .../v1.0/2355_saboteur_steal_cash_amount.yaml | 2 +- ...eur_internet_center_sabotage_duration.yaml | 21 +++++++++++++++++++ .../Data/INI/Object/DemoGeneral.ini | 4 +++- .../Data/INI/Object/GLAInfantry.ini | 4 +++- .../Data/INI/Object/StealthGeneral.ini | 4 +++- 5 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 Patch104pZH/Design/Changes/v1.0/2357_saboteur_internet_center_sabotage_duration.yaml diff --git a/Patch104pZH/Design/Changes/v1.0/2355_saboteur_steal_cash_amount.yaml b/Patch104pZH/Design/Changes/v1.0/2355_saboteur_steal_cash_amount.yaml index 23e2f2816..89114df40 100644 --- a/Patch104pZH/Design/Changes/v1.0/2355_saboteur_steal_cash_amount.yaml +++ b/Patch104pZH/Design/Changes/v1.0/2355_saboteur_steal_cash_amount.yaml @@ -4,7 +4,7 @@ date: 2023-09-13 title: Increases steal cash amount of GLA Saboteur from 1000 to 1200 changes: - - tweak: Increases the steal cash amount of the GLA Saboteur from 1000 to 1200. + - tweak: Increases the steal cash amount of the GLA Saboteur from 1000 to 1200. The maximum cash gain factor against a Supply Center increases from 2.5 to 3.0. labels: - buff diff --git a/Patch104pZH/Design/Changes/v1.0/2357_saboteur_internet_center_sabotage_duration.yaml b/Patch104pZH/Design/Changes/v1.0/2357_saboteur_internet_center_sabotage_duration.yaml new file mode 100644 index 000000000..18bd3698d --- /dev/null +++ b/Patch104pZH/Design/Changes/v1.0/2357_saboteur_internet_center_sabotage_duration.yaml @@ -0,0 +1,21 @@ +--- +date: 2023-09-13 + +title: Increases Internet Center sabotage duration of GLA Saboteur from 15 to 60 seconds + +changes: + - tweak: Increases the Internet Center sabotage duration of the GLA Saboteur from 15 to 60 seconds. The average cash gain factor against an Internet Center with 8 Hackers increases from 0.68 to 2.72. Internet Center upgrade research and Satellite Hack I & II are paused for the same sabotage duration. + +labels: + - buff + - controversial + - design + - gla + - minor + - v1.0 + +links: + - https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2357 + +authors: + - xezon diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini index 5648733dd..d243b2b13 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini @@ -17456,7 +17456,7 @@ Object Demo_GLAInfantrySaboteur ; Patch104p @bugfix commy2 10/10/2021 Add ability to enter Supply Drop Zones and Black Markets. ; Patch104p @tweak xezon 13/09/2023 Changes steal cash amount from 1000. (#2355) - ; Max gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. + ; Max cash gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. Behavior = SabotageSupplyDropzoneCrateCollide SabotageTag_02 BuildingPickup = Yes @@ -17483,6 +17483,8 @@ Object Demo_GLAInfantrySaboteur BuildingPickup = Yes End ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) + ; Cash gain factor varies with amount of Hackers and their veterancy level(s). + ; Average cash gain factor with 8 Hackers is 2.72x: -800 build cost (+36.25 cash/second * 60 seconds) = 1375 gain. Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes SabotageDuration = 60000 diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini index ee17648be..4e2d88d05 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/GLAInfantry.ini @@ -4411,7 +4411,7 @@ Object GLAInfantrySaboteur ; Patch104p @bugfix commy2 10/10/2021 Add ability to enter Supply Drop Zones and Black Markets. Prevents ability to tell apart fake and real Black Markets by cursor. ; Patch104p @tweak xezon 13/09/2023 Changes steal cash amount from 1000. (#2355) - ; Max gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. + ; Max cash gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. Behavior = SabotageSupplyDropzoneCrateCollide SabotageTag_02 BuildingPickup = Yes @@ -4435,6 +4435,8 @@ Object GLAInfantrySaboteur BuildingPickup = Yes End ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) + ; Cash gain factor varies with amount of Hackers and their veterancy level(s). + ; Average cash gain factor with 8 Hackers is 2.72x: -800 build cost (+36.25 cash/second * 60 seconds) = 1375 gain. Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes SabotageDuration = 60000 diff --git a/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini b/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini index 6597f03bd..0b2812c5d 100644 --- a/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini +++ b/Patch104pZH/GameFilesEdited/Data/INI/Object/StealthGeneral.ini @@ -17820,7 +17820,7 @@ Object Slth_GLAInfantrySaboteur ; Patch104p @bugfix commy2 10/10/2021 Add ability to enter Supply Drop Zones and Black Markets. ; Patch104p @tweak xezon 13/09/2023 Changes steal cash amount from 1000. (#2355) - ; Max gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. + ; Max cash gain factor is 3x: -800 build cost +1200 reward +1200 enemy loss = 1600 gain. Behavior = SabotageSupplyDropzoneCrateCollide SabotageTag_02 BuildingPickup = Yes @@ -17847,6 +17847,8 @@ Object Slth_GLAInfantrySaboteur BuildingPickup = Yes End ; Patch104p @tweak xezon 13/09/2023 Changes sabotage duration from 15000 to achieve fair value. (#2357) + ; Cash gain factor varies with amount of Hackers and their veterancy level(s). + ; Average cash gain factor with 8 Hackers is 2.72x: -800 build cost (+36.25 cash/second * 60 seconds) = 1375 gain. Behavior = SabotageInternetCenterCrateCollide SabotageTag_08 BuildingPickup = Yes SabotageDuration = 60000