-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improve Daisy Cutter explosion effect and sound sequence, remove destruction delay variance #1800
Conversation
38147fe
to
77f5c10
Compare
77f5c10
to
9f3d097
Compare
I made another pass on this and fixed up the entire Daisy Cutter explosion sequence. The effects are now better in sync. New representative videos have been attached. |
9f3d097
to
9039ac5
Compare
9039ac5
to
85e424a
Compare
85e424a
to
765eceb
Compare
Reverted the tweaks to the smoke particles. Original effect looks ok. Reverted change to destruction delay. It no longer tries to compensate for removal of delay variance. For Aurora bomb explosion we also did not compensate and left it at 1000 ms. See #1752. So to keep it consistent, doing the same with Daisy Cutter bomb. Added Buff and Controversial labels accordingly. Documentation added. Video not updated. Explosion effect sequence looks good to me. |
765eceb
to
e4a46f8
Compare
Merge with Rebase
This change fixes up the entire Daisy Cutter explosion effect and sound sequence.
The sound is used for Fuel Bomb, MOAB, Alpha Aurora, Bunker Buster.
Patched, before this change
generals.2023-04-10.13-46-50-21.mp4
Patched, after this change
generals.2023-04-10.13-41-44-57.mp4