Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve Daisy Cutter explosion effect and sound sequence, remove destruction delay variance #1800

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Apr 6, 2023

Merge with Rebase

This change fixes up the entire Daisy Cutter explosion effect and sound sequence.

  • Removes the destruction delay variance of 100 ms
  • Removes the 250 ms delay baked into the explosion audio effect.
  • Adds smooth fade out to the explosion audio effect.
  • Syncs the ignition particles better with the ignition sound.
  • Syncs the explosion effects better with the explosion sound.

The sound is used for Fuel Bomb, MOAB, Alpha Aurora, Bunker Buster.

Patched, before this change

generals.2023-04-10.13-46-50-21.mp4

Patched, after this change

generals.2023-04-10.13-41-44-57.mp4

@xezon
Copy link
Collaborator Author

xezon commented Apr 10, 2023

I made another pass on this and fixed up the entire Daisy Cutter explosion sequence. The effects are now better in sync. New representative videos have been attached.

@xezon xezon changed the title Fix: Remove initial explosion delay from Daisy Cutter explosion sound Fix: Improve Daisy Cutter explosion effect and sound sequence, remove destruction delay variance Apr 10, 2023
@xezon xezon added the Design Is a matter of game design label Apr 10, 2023
@xezon xezon force-pushed the daisy-cutter-expl-sound branch from 9f3d097 to 9039ac5 Compare April 10, 2023 12:18
@xezon xezon added the Controversial Is controversial label Apr 18, 2023
@xezon
Copy link
Collaborator Author

xezon commented Apr 18, 2023

Reverted the tweaks to the smoke particles. Original effect looks ok.

Reverted change to destruction delay. It no longer tries to compensate for removal of delay variance. For Aurora bomb explosion we also did not compensate and left it at 1000 ms. See #1752. So to keep it consistent, doing the same with Daisy Cutter bomb. Added Buff and Controversial labels accordingly.

Documentation added. Video not updated. Explosion effect sequence looks good to me.

@xezon xezon force-pushed the daisy-cutter-expl-sound branch from 765eceb to e4a46f8 Compare April 18, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related Buff Makes a thing more powerful Controversial Is controversial Design Is a matter of game design Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant