Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Demo General Combat Bike With Demolitions Upgrade Deals No Damage When Destroyed By Gamma Poison #104

Merged
merged 4 commits into from
Sep 10, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 28, 2021

ZH 1.04

  • The Demo General's Combat Bike with a Terrorist and the Demolitions upgrade deals no damage to enemies when destroyed by an Anthrax Gamma weapon only.

With patch:

  • The type of poison has no influence on the death weapon being fired.

@commy2 commy2 added the Bug Something is not working right label Aug 28, 2021
@xezon xezon self-requested a review August 29, 2021 12:43
@xezon
Copy link
Collaborator

xezon commented Aug 29, 2021

This will make Tox with Gamma upgrade a bit weaker against Demo Bikes. Tunnels would essentially not able to stop demo bikes without taking damage anymore. We need this reviewed by the Balance boys.

@commy2 commy2 added the OngoingDiscussion Requires further discussion label Aug 29, 2021
@ReLaX82
Copy link

ReLaX82 commented Aug 29, 2021

I don't get it, maybe someone would be so kind to explain?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 29, 2021

Imagine a Demo Bike upgraded with Demolitions upgrade.

If you kill it with green or blue poison, it explodes as if you had suicided it.
But if you kill it with pink poison, it is just killed without exploding.

Extra weird is that this distinction does not happen before the Demolitions upgrade.

It's a bug / typo in the ini files.

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 3, 2021

Never heard of this one before

If anthrax alpha and beta don't cause this, then so shouldn't gamma

  • It will balance the tox demo MU a bit more so yeah i vote fix

@xezon
Copy link
Collaborator

xezon commented Sep 3, 2021

I am also in favor of this change for consistency sake. It would avoid random moments, where demo bike explodes infront of army but deals no damage, just because the last shot was dealt by the Gamma Toxin.

@commy2 commy2 merged commit aff4799 into main Sep 10, 2021
@commy2 commy2 deleted the fix-demo-bike-gamma-poison-death branch September 10, 2021 18:30
@commy2 commy2 removed the OngoingDiscussion Requires further discussion label Sep 10, 2021
xezon pushed a commit that referenced this pull request Sep 10, 2021
@xezon xezon added Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Oct 2, 2021
xezon pushed a commit that referenced this pull request Aug 28, 2022
@xezon xezon added Buff Makes a thing more powerful GLA Affects GLA faction labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Bug Something is not working right Controversial Is controversial GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants