Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

China Nuclear Missile has small effective damage radius #846

Closed
xezon opened this issue Aug 6, 2022 · 68 comments · Fixed by #871
Closed

China Nuclear Missile has small effective damage radius #846

xezon opened this issue Aug 6, 2022 · 68 comments · Fixed by #871
Labels
Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 6, 2022

China Nuclear Missile has small effective damage radius.

WIP: Create comparison with GLA SCUD Storm and USA Particle Cannon.

@xezon xezon added Design Is a matter of game design Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Aug 6, 2022
@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

Superweapon Area Damage Test

Here is area damage test of vanilla Superweapons. Tested on 8 x 8 GLA Blackmarkets. Note that China Nuke Missile has the multi blast fix applied to kill the GLA holes properly.

USA Particle Cannon

damage_area_particle.mp4

China Nuke Missile

damage_area_nuke.mp4

GLA Scud Storm

damage_area_scud.mp4

Result

Object Num Destroyed Num Damaged Num Undamaged
Original USA Particle Cannon 14 2 48
Patched China Nuke Missile 14 9 41
Original GLA SCUD Storm 27 29 8

Conclusion

Area damage of USA Particle and China Missile are comparable. 1 GLA SCUD Storm can kill twice as much as 1 China Nuke Missile and can further damage 3 times as much as 1 China Nuke Missile. The GLA SCUD Storm is without a doubt the most powerful Superweapon when it comes to area damage.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

Superweapon Point Damage Test

Here is point damage test of vanilla Superweapons. Tested on 5 x 5 GLA SCUD Storm. Note that China Nuke Missile has the multi blast fix applied to kill the GLA holes properly.

USA Particle Cannon

point_damage_particle.mp4

China Nuke Missile

point_damage_nuke.mp4

GLA Scud Storm

point_damage_scud.mp4

Result

With health bar status on center target structure we can measure the applied damage.

Object Damage Applied
Original USA Particle Cannon 85 %
Patched China Nuke Missile 70 %
Original GLA SCUD Storm 90 %

Conclusion

SCUD Storm achieves best point damage. Particle Cannon is close, but cannot achieve area damage when focusing on one point. China Nuke Missile applies the least damage by far.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

I think something needs to be done here. This is not fair at all.

@commy2
Copy link
Collaborator

commy2 commented Aug 11, 2022

  • Gamma SCUD (+10% damage) and Demo Scud (+20% damage) would make this comparison look even worse.
  • SWG Particle is pink, but as far as I can tell, is identical stats wise.
  • Nuke General Nuke Silo comes at 10% discount ($4500).
  • One drawback of SCUD Storm is that it has 120s build time (compared to 60s for PC and Nuke), because GLA has no power, so time from investment to first shot is identical to the Nuke.
  • It also took 5 seconds for the Nuke to arrive at the target compared to 10 seconds of the SCUD Storm. This is important when using the super weapon against mobile armies. The time of flight also depends on how far from target the super weapon is placed. However, SCUD will generally take longer, because the missiles have to raise first.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

Another question is how much damage the Nuke does with Fortified Structures

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

This was enough testing from my side. The data is conclusive enough.

@commy2
Copy link
Collaborator

commy2 commented Aug 11, 2022

Another question is how much damage the Nuke does with Fortified Structures

  • SCUD Storm and Nuke Silo both deal EXPLOSION damage
  • Fortified Structures does reduce the damage taken from EXPLOSION type weapons by 25%.
  • Fortified Structures does reduce the damage taken from PARTICLE_BEAM type weapons by 25%, except for the Command Center, where it is 28% instead.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 11, 2022

Superweapon Point Damage Test

I don't think This test was done properly, Nuke and Scud Distributes the damage on crowded buildings, should have done it on a single Building with nothing around it.

Also particle Cannon does more damage if moved around, so I've heard, not certain.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

Please proof this.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 11, 2022

Will get a test of it soon

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

Fortified Structures NEEDS to be tested though, because it's a very meta upgrade that's cheap and effective.

The first test vs Markets will look totally different, because the Particle can still destroy the same amount of buildings (maybe two less), whereas the Nuke will suffer alot more I predict.

Btw sorry, I would like to test this myself, but have no time currently in learning how to build maps, unless very easy?

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

USA and China have no Fortified Upgrade. No idea why you guys focus so much on that... meaning you can test a thousand combinations of different structures, and angles, and buffs... the result will always be the same that SCUD Storm is OP.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 11, 2022

Scud Storm is the more powerful super weapon. Any change we do, should be a buff to the other super weapons, not a nerf to the Scud Storm.

Although I would like to add, China and USA get General Powers that destroy buildings, whereas GLA doesn't (apart from Demo).

So perhaps that's why they do less, as you can combine with GPs.

Also, they differ, PC is instant, and can move from unit to unit. Is good vs buildings but just not as many as Scud Storm.

Nuke is also very fast and does good damage vs armies, not so good vs buildings (of course with the GLA hole damage change we did, it will be better).

Scud Storm is very good vs buildings, but not the best for tracking down moving units (can still work).

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

USA and China have no Fortified Upgrade. No idea why you guys focus so much on that...

We need to know how it (will) performs vs GLA, it's a practicality test since (Fortified) Markets are one of the priority targets for China.

Currently China needs to use Genpowers in combination to destroy Fortified Markets, whereas USA does not.

Therefore my buff suggestion would be increasing the damage just enough to make it perform exactly like the test above vs Markets, but then with Fortified Structures. *If this wouldn't make the concentrated power too much vs other highly armored structures.

Btw, Scud-Storm also deserves to be the strongest since GLA has no other Destructive Genpowers (except Demo Rebel Ambush).

@commy2
Copy link
Collaborator

commy2 commented Aug 11, 2022

Although I would like to add, China and USA get General Powers that destroy buildings, whereas GLA doesn't

This is an important point.

My buff suggestion would be increasing the damage just enough to make it perform exactly like the test above vs Markets, but then with Fortified Structures.

That'd mean +33.333333% damage to Nuke Silo. I am only in favour of that if it does not one shot super weapons and Command Centers due to that.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

That'd mean +33.333333% damage to Nuke Silo. I am only in favour of that if it does not one shot super weapons and Command Centers due to that.

I agree, that wouldn't be fair, hence I added the note * if that would be the case.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

Although I would like to add, China and USA get General Powers that destroy buildings, whereas GLA doesn't (apart from Demo).

It is an argument, but not a strong one. General Powers are limited in numbers. Superweapons typically can be build in unlimited quantities. Therefore a SCUD Storm being twice as good as Nuke Missile makes no sense.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

Although I would like to add, China and USA get General Powers that destroy buildings, whereas GLA doesn't (apart from Demo).

It is an argument, but not a strong one. General Powers are limited in numbers. Superweapons typically can be build in unlimited quantities. Therefore a SCUD Storm being twice as good as Nuke Missile makes no sense.

It is a strong argument. If we would make Nuke similar to Scud, then it would be totally OP in combination with Genpowers in typical 1v1, 2v2 and 3v3 matches.

In your scenario example the quantity of SW's would make impact of Genpowers insignificant, to the extent where we could give GLA the same Genpowers and it wouldn't make a difference.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

If GLA builds 5 SCUD Storms, then it essentially has 10 Nuke Missiles worth of firepower.

Meanwhile China with 5 Nuke Missiles, would have 6 Nuke Missiles worth of Firepower with its Artillery and Bomber.

How does this balance exactly?

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

If GLA builds 5 SCUD Storms, then it essentially has 10 Nuke Missiles worth of firepower.

Meanwhile China with 5 Nuke Missiles, would have 6 Nuke Missiles worth of Firepower with its Artillery and Bomber.

How does this balance exactly?

If 5 Nukes are worth 5 Particles of firepower that would good enough of an improvement. We don't need to give China Scudstorms.

@xezon
Copy link
Collaborator Author

xezon commented Aug 11, 2022

chinapowers.mp4

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 11, 2022

chinapowers.mp4

To destroy 2 enemy Scudstorms, China needs 2 Nukes and his Genpowers (if Carpet Bomber can reach target).

GLA needs 4 Scudstorms (Demo needs 2).

@ZekeDlyoung
Copy link

This happens when you use multiple blasts for the nuclear missile but give it a growing damage radius, for some reason that part of the code doesn't work very well (or at least I haven't been able to make it work correctly)

A simple fix for this would be to make all the blast waves have the same radius (and perhaps the same damage as well if you you want absolute uniformity)

@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2022

The aftermath would be identical with the 1.04 Nuke, except from the holes surviving. The multi blast PR was designed that way. The mechanics of the nuke are well understood at this point.

@ZekeDlyoung
Copy link

I don't think making it act like the 1.04 nuke is a bad thing, the only problem it had was leaving holes, most players don't know about the growing radius, and I doubt they would want it more than a consistent area deleter

@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2022

I think we agree that in order to avoid overkill before holes, damage has to be dealt in steps. Your approach seems to be to make each of these steps identical (hopefully I got it now).

My approach is to maximize the constant damage area for each step in such a way that I keep the total damage at each position identical to 1.04.

The graphic you posted displays tallies. A better visualization may be this:

Figure_1

As you can see, I minimize the area affected by the falling off slope on all steps. The advantage of constant damage is that overkill scenarios become predictable.

I concede that the time intervals were just taken by what EALA entered. I found nothing wrong with them.

It would probably be better to have the blasts in reverse: first damage outer most area, then decrease radius until the smallest blast area. That way the "slope" would be transferred completely to any hole or bunkered Battle Bus. But that would either look very wrong or require all blasts to happen at basically same time (1 frame difference probably).

@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2022

I did review the math commy2 applied to patched Nuke Missile back then and it checked out, meaning it should apply exact same damage as original.

@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2022

^ This. While also going for maximum Hole ownage.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 13, 2022

Superweapon Point Damage Test

I don't think This test was done properly, Nuke and Scud Distributes the damage on crowded buildings, should have done it on a single Building with nothing around it.

Also particle Cannon does more damage if moved around, so I've heard, not certain.

Ok, Test Result is here

Moving Particle Cannon for More Damage=BS

Particle

Nuclear Missile On isolated Building=More Damage

Nuke

SCUD Missile On isolated Building=More Damage

Scud

it's a little harder to spot on The Scud But it looks like more damage to me, also i think it's a bit more random and it depends on where do the Missiles fall

NOTE: Test Was Made on Main Branch

@commy2
Copy link
Collaborator

commy2 commented Aug 13, 2022

Moving Particle Cannon for More Damage=BS

Good to know that others fail to reproduce this as well.

a bit more random and it depends on where do the Missiles fall

Just for the record, the missiles will deterministically hit the same positions every time.

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 13, 2022

Just for the record, the missiles will deterministically hit the same positions every time

I could've swore I've seen them fall differently sometimes, like the time of landing, sometimes they fall at the same moment sometimes a bit different, but i guess this changes depending on the orientation of the building and the angle of the launch relative to the SCUD which would make some fall before others Vice versa.

@commy2
Copy link
Collaborator

commy2 commented Aug 13, 2022

Moment may change depending on the orientation of the Scud Storm and direction of target and probably the terrain, but positions are fixed.

@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2022

I can't replicate the claim about more damage applied to isolated structure. Here is my test result. Shot with SCUD Storm. Damage amount looks same. Please test again and provide side by side comparison.

Edit: Also tested with Nuke Missile. Also same damages.

shot_20220813_215704_1

shot_20220813_215742_2

@MTKing4
Copy link
Collaborator

MTKing4 commented Aug 13, 2022

I wasn't very sure about the SCUD Either, but i Compared the Nuke with the Video above

Here's a SS of that

Screenshot_20220813-231809_Chrome

Compared to mine

Nuke

I'll do more testing later as I'm off now.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 14, 2022

Just tested it, damage radius seems to match the Targeting Cursor and it does kill Fortified Markets just like Scuds and Particles do.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

Ok, so right now the Scud and Nuke are pretty much similar, generally I like the improvement but shouldn't they have some more diversified pros and cons? That would make it more interesting imo since the weapons our quite different in their nature.

What about increasing the Nuke's center damage, but making the radius slightly smaller. It would make sense since the Scud Missiles spread out over a large area right?

Example model:

  • Nuke can 1 Shot a Scud to the hole, same like the Demo Scud.
  • Outer radius will only kill Fortified Markets to the hole.

Example result:
6 minutes cooldown might now be justified, it won't be a weapon of mass destruction (on it's own vs economy), but China has more potential keeping up with the SW race. Genpowers are needed to finish off holes.

@xezon
Copy link
Collaborator Author

xezon commented Aug 15, 2022

I am not entirely comfortable with such buff on Nuke Missile. It would make it much better than Particle and regular SCUD. We would need some evidence that China would still struggle in Superweapon wars with the current adjustments.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

I am not entirely comfortable with such buff on Nuke Missile. It would make it much better than Particle and regular SCUD. We would need some evidence that China would still struggle in Superweapon wars with the current adjustments.

Well, why does Demo deserve to have a SW like this, with a good radius aswell?

@xezon
Copy link
Collaborator Author

xezon commented Aug 15, 2022

I think not. It gives Demo General big advantage in Superweapon war. We could reduce...

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 15, 2022

I think Nuke is fine at the moment. There isn't a need to make it even better.

Regarding Demo Scud, yes it is stronger. But I don't think we should nerf it, same for Tox. We've buffed 4 Nukes, which I think is a good thing.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

@xezon

I am not entirely comfortable with such buff on Nuke Missile. It would make it much better than Particle and regular SCUD. We would need some evidence that China would still struggle in Superweapon wars with the current adjustments.

@Jundiyy

I think Nuke is fine at the moment. There isn't a need to make it even better.

Regarding Demo Scud, yes it is stronger. But I don't think we should nerf it, same for Tox. We've buffed 4 Nukes, which I think is a good thing.

The idea is not to make the Nuke better than other SW's, it's to diversify it by giving it pros and cons. Both can be tweaked till we reach desired result.

I'm also wary about nerfing Demo Scud btw, only if we can do it by giving it logical pros and cons.

@Stubbjax
Copy link
Collaborator

I think the Nuke being fast enough to take out large armies is already enough of a differentiator and more interesting.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

I think the Nuke being fast enough to take out large armies is already enough of a differentiator and more interesting.

So basically it's better than the Scud right now, same performance but much faster.

@xezon
Copy link
Collaborator Author

xezon commented Aug 15, 2022

The SCUD Storm does have better range.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

The SCUD Storm does have better range.

Doesn't seem as significant as the Missile speed difference though, the bonus range of the Scud can't finish off extra buildings in the SDZ test, which are relatively low HP. So in practice, not a real difference in range.

Think we haven't taken this factor (missile speed) into account enough tbf.

@xezon
Copy link
Collaborator Author

xezon commented Aug 15, 2022

SCUD Storm applies significantly more damage for Toxin and Demo, can be stealthed with Kassad, has no power outages, does have measurable better damage radius, has better countdown of 5:00 minutes.

The better damage radius is measureable as per research shown. In the Black Market test, it damages 2.5 times as many buildings as Nuke Missile does.

I think it is mistake to ignore the SCUD Storm perks and claim that China Nuke Missile is better.

@Stubbjax
Copy link
Collaborator

And leaves a hole + has Fortified Structures upgrade.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

@xezon

SCUD Storm applies significantly more damage for Toxin and Demo, can be stealthed with Kassad, has no power outages, does have measurable better damage radius, has better countdown of 5:00 minutes.

The better damage radius is measureable as per research shown. In the Black Market test, it damages 2.5 times as many buildings as Nuke Missile does.

* [Change: Increase China Nuke Missile damage by 20% and blasts radii by 2%, 3.3%, 4%, 4.4%, 4.7%, 20% #871](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/871)

I think it is mistake to ignore the SCUD Storm perks and claim that China Nuke Missile is better.

@Stubbjax

And leaves a hole + has Fortified Structures upgrade.

True, all those factors besides damage radius (or Fortified Structures*) are quite significant and probably outweigh missile speed.

However I feel that damaged buildings in the outer radius don't impact the game that much, unless you have a direct follow up to quickly kill those buildings.

Raw damage output of Demo Scud makes more of a difference. Gamma Scud damages enemy Scud down to like 1HP, Demo down to hole, now this tiny difference is very significant. In the radius example the Demo Scud only kills 1 extra building in SDZ test.

*Btw, don't think Fortified Structures affect Scuds.

@xezon
Copy link
Collaborator Author

xezon commented Aug 15, 2022

Outer radius damage stacks if player fires 2 Superweapons.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 15, 2022

Outer radius damage stacks if player fires 2 Superweapons.

That's also true.

Still happy about changes overall :)

@Stubbjax
Copy link
Collaborator

*Btw, don't think Fortified Structures affect Scuds.

You're right! It uses an entirely separate 'tough' armour, which all super weapons share. There's still more likely to be a worker nearby to repair it though. Also keep in mind that the outer SCUD damage, while maybe not enough to destroy buildings, will still likely destroy units.

@ImTimK
Copy link
Collaborator

ImTimK commented Jul 7, 2023

Radation damage and duration is dissapointing, perhaps swap that with the Scudstorm. With the Scudstorm having 95% of the pros, the Nuclear Missile deserves a little something doesn't it?

Another redesign would be to swap the decay only, so that Nuclear radiation has the longer decay (realistic), but less damage than Anthrax.

@xezon
Copy link
Collaborator Author

xezon commented Jul 7, 2023

Nuke Missile

Object NukeRadiationFieldWeapon
  Behavior = LifetimeUpdate ModuleTag_04
    MinLifetime = 30000
    MaxLifetime = 30000
  End
End

Weapon NukeRadiationFieldWeapon
  PrimaryDamage = 25.0
  PrimaryDamageRadius = 200.0
  DamageType = RADIATION
  DeathType = NORMAL
  WeaponSpeed = 600                     ;  dist/sec
  RadiusDamageAffects = ALLIES ENEMIES NEUTRALS NOT_AIRBORNE
  DelayBetweenShots = 750                ; time between shots, msec
End

Scud Missile (multiples)

Object PoisonFieldLarge
  Behavior = LifetimeUpdate ModuleTag_04
    MinLifetime = 45000  ; 45 seconds
    MaxLifetime = 45000
  End
End

Weapon LargePoisonFieldWeapon
  PrimaryDamage = 15.0
  PrimaryDamageRadius = 140.0
  DamageType = POISON
  DeathType = POISONED
  WeaponSpeed = 600                     ;  dist/sec
  RadiusDamageAffects = ALLIES ENEMIES NEUTRALS NOT_AIRBORNE
  DelayBetweenShots = 500                ; time between shots, msec
End

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
7 participants